Skip to content

L
linux-davinci
Switch branch/tag
  1. 15 Aug, 2007 7 commits
    • David Brownell's avatar
      tsc210x cleanup · 35d23ec1
      David Brownell authored 
      This is mostly cleanup of the tsc210x patch, but some bugs were fixed so now
it works on tsc2101 too.  Also, a few issues are now noted in the code:

 Tool-reported:
  - Address checkpatch.pl issues in the original patch
  - And also "sparse" issues

 Previously wrong:
  - Cope with CONFIG_SOUND_MODULE
  - Register accessor routines will now return error codes
  - ... many callers now abort cleanly after errors
  - Don't depend on seeing only a rev #1 tsc2102 chip!
  - Add missing EXPORT_SYMBOL declarations

 Style issues:
  - BUG_ON() is strongly to be avoided
  - So are macros that capture variables
  - And needless casting from void pointers
  - And type punning
  - Use dev_*() for messaging where practical
  - Use u16 not uint16_t, etc
  - Various other whitespace issues
  - Avoid __FUNCTION__
  - Single-lines for file-top comments; no whole paths

 Object code size and Other cleanup:
  - Compile most strings out unless -DDEBUG is configured (saving space)
  - Move some code into exit sections (then it may well vanish, saving space)
  - Add some header comments

 Open issues:
  - Hwmon needs to know VREF and the chip type, and to scale its values
  - Upstream push should exclude audio until some version is working
  - Audio will needs to export symbols to modules, too
  - Lots of the I/O calls (especially audio) still don't handle errors
  - How could board init code get board-specific temp calibration data?

Also the Kconfig is more open-ended; tsc210x might in the future include the
tsc2100 and tsc2111, it doesn't need to be limited to tsc2101 and tsc2102.
Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
      35d23ec1
    • David Brownell's avatar
      menelaus minor cleanups · d37654d3
      David Brownell authored 
      Remove duplicate Menelaus Kconfig entry (omap tree only).

Fix Menelaus build error, and remove needless "#define DEBUG" (goes upstream).
Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
      d37654d3
    • David Brownell's avatar
      mcspi can be modular... · 5d8da87b
      David Brownell authored 
      Don't assume only non-modular builds.  Just in case someone's crazy.
Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      5d8da87b
    • David Brownell's avatar
      remove useless/wrong P20_24XX_TSC_IRQ mux · bc3fd0c4
      David Brownell authored 
      Remove bogus TSC_IRQ pinmux; it's not used, there's no pin
dedicated for touchscreen (or other TSC chip) purposes, and
this doesn't even look right for P20 (0x10b not 0x108, plus
an IRQ would need to be a GPIO i.e. mux 3 not mux 0).
Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      bc3fd0c4
    • Tony Lindgren's avatar
      musb_hdrc: Keep tusb host clock on when VBUS is on · eca6bbd9
      Tony Lindgren authored 
      Otherwise host mode will not work when OMAP idles
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      eca6bbd9
    • Tony Lindgren's avatar
      musb_hdrc: Stop VBUS draw on usb_gadget_unregister_driver · c5d9f0a5
      Tony Lindgren authored 
      If musb_gadget_vbus_draw() also toggles a clock like tusb does,
USB clock will stay on after rmmoding a gadget driver. This
can block omap idle states.

Also handle disconnect as b_idle so that musb_gadget_vbus_draw()
gets called.
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      c5d9f0a5
    • Tony Lindgren's avatar
      musb_hdrc: Fix ambiguous else warning · 9274e1e0
      Tony Lindgren authored 
      Fix ambiguous else warning
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      9274e1e0
  3. 14 Aug, 2007 3 commits
  5. 13 Aug, 2007 30 commits