- 06 Dec, 2009 5 commits
-
-
Rémi Denis-Courmont authored
-
Rémi Denis-Courmont authored
This reverts commit 59b025e3.
-
Rémi Denis-Courmont authored
Those functions automatically abort if allocation fails (which is not quite the same as calling assert()). Avoid these functions in new code.
-
Rémi Denis-Courmont authored
Those are the same as the Linux kernel macros, and probably a bunch of other projects. Usage: if (likely(condition)) branch_likely_taken(); if (unlikely(condition)) branch_unlikely_taken(); Attention: those two macros convert the predicate to a boolean value. Therefore you generally cannot use them for assignments like this: void *p_sys = likely (malloc (sizeof (*p_sys))); if (!p_sys) return VLC_ENOMEM; Instead you can do this: void *p_sys = malloc (sizeof (*p_sys)); if (unlikely (!p_sys)) return VLC_ENOMEM;
-
Pierre Ynard authored
-
- 05 Dec, 2009 35 commits
-
-
JP Dinger authored
-
JP Dinger authored
-
JP Dinger authored
Replace argument = realloc( argument, size ); with realloc_or_free() in modules/*, and while at it add assert( argument ) to mark unhandled ENOMEM conditions, also for malloc().
-
JP Dinger authored
Introduce realloc_or_free() to src/*, and add assert() to mark unhandled ENOMEM error conditions. Allocation shrinking or otherwise handled allocations don't need realloc_or_free.
-
JP Dinger authored
Introduce realloc_or_free(), which does what realloc() does but will free the argument if the reallocation fails. This is useful in some, but not all, use cases of realloc().
-
JP Dinger authored
-
JP Dinger authored
-
JP Dinger authored
Skins2: Add x11 transparency support. Hope it sets the property on the right Window; didn't have a known transparent skin to test with.
-
JP Dinger authored
Skins2: Cosmetics and drop const from string return as there really is no point: We're returning a fresh object.
-
JP Dinger authored
Skins2: Move method bodies with inline tags to before where they're needed. Drop const in favour of static on power() and instead of recursing(!) make it use powf().
-
JP Dinger authored
skins2: I fail to see why Subject (not Observer) needs to have virtual methods. If you do find a reason do tell. Observer should probably be defined inside Subject instead.
-
JP Dinger authored
-
JP Dinger authored
-
JP Dinger authored
Skins2: Mostly cosmetics, some C++ style casting, factor out a scroll() in anticipation of figuring out where it belongs.
-
JP Dinger authored
-
JP Dinger authored
-
JP Dinger authored
-
JP Dinger authored
-
JP Dinger authored
-
JP Dinger authored
-
JP Dinger authored
-
JP Dinger authored
Skins2: Add (and use) template parameter typedefs so that they might be used, say, as function return types. The next commit needs this.
-
JP Dinger authored
-
JP Dinger authored
Skins2: Factor out duplicate code (mod), and provide a const accessor to the keymap: std::map<>::operator[] will create empty nodes if they don't exist already.
-
JP Dinger authored
-
JP Dinger authored
-
JP Dinger authored
-
JP Dinger authored
-
JP Dinger authored
Skins2: x11_display: Replace PUT_PIXEL and BLEND_PIXEL macros with templates. Could use more testing and possibly more refactoring.
-
JP Dinger authored
-
JP Dinger authored
-
JP Dinger authored
-
JP Dinger authored
-
JP Dinger authored
Skins2: Use vlc KEY_MODIFIER_* constants for key modifier masks, simplifying the code. Revert from enum to static const int to not have to include vlc_keys.h through the header file.
-
JP Dinger authored
-