Commit 49c1e2a7 authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont

Remove bogus vlc_object_wait (no condition to wait on)

N.B.: libvlc snapshots remain seriously broken.
Vout is not locked when shooting. Variables are not safely set.
Vout thread does not access request field safely.
Multiple requests are not safe either. I probably missed some other
issues.
parent 8093b7f2
...@@ -92,7 +92,6 @@ mediacontrol_snapshot( mediacontrol_Instance *self, ...@@ -92,7 +92,6 @@ mediacontrol_snapshot( mediacontrol_Instance *self,
vlc_object_lock( p_cache ); vlc_object_lock( p_cache );
vout_Control( p_vout, VOUT_SNAPSHOT ); vout_Control( p_vout, VOUT_SNAPSHOT );
vlc_object_wait( p_cache );
vlc_object_release( p_vout ); vlc_object_release( p_vout );
p_snapshot = ( snapshot_t* ) p_cache->p_private; p_snapshot = ( snapshot_t* ) p_cache->p_private;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment