1. 06 Jan, 2015 1 commit
  2. 03 Jan, 2015 6 commits
  3. 02 Jan, 2015 4 commits
  4. 31 Dec, 2014 5 commits
  5. 30 Dec, 2014 2 commits
  6. 29 Dec, 2014 1 commit
  7. 19 Dec, 2014 1 commit
  8. 18 Dec, 2014 2 commits
  9. 17 Dec, 2014 10 commits
  10. 13 Dec, 2014 7 commits
  11. 12 Dec, 2014 1 commit
    • Fabian Yamaguchi's avatar
      stream_out: rtp: don't use VLA for user controlled data · 3199c5dd
      Fabian Yamaguchi authored
      It should fix a possible invalid memory access
      
      When streaming ogg-files via rtp, an ogg-file can trigger an invalid
      write access using an overly long 'configuration' string.
      
      The original code attemps to allocate space to hold the string on the stack
      and hence, cannot verify if allocation succeeds. Instead, we now allocate the
      buffer on the heap and return if allocation fails.
      
      In detail, rtp_packetize_xiph_config allocates a buffer on the stack at (1) where
      the size depends on the local variable 'len'. The variable 'len' is
      calculated at (0) to be the length of a string contained in a specially
      crafted Ogg Vorbis file, and therefore, it is attacker-controlled.
      Signed-off-by: default avatarJean-Baptiste Kempf <jb@videolan.org>
      (cherry picked from commit 204291467724867b79735c0ee3aeb0dbc2200f97)
      Signed-off-by: default avatarJean-Baptiste Kempf <jb@videolan.org>
      3199c5dd