Commit 43b340cf authored by Suman Anna's avatar Suman Anna Committed by Hari Kanigeri

SYSLINK: ipc - removed gt_traces from messageq_transportshm & heapbuf modules

This patch cleaned up all the gt_traces in messageq_transportshm and heapbuf
modules. Duplicate BUG_ONs have also been removed. return statements have
been added in couple of functions for successful execution scenarions.
Signed-off-by: default avatarSuman Anna <s-anna@ti.com>
parent 7ef35685
...@@ -18,7 +18,7 @@ ...@@ -18,7 +18,7 @@
#include <linux/types.h> #include <linux/types.h>
#include <linux/bug.h> #include <linux/bug.h>
#include <gt.h>
#include <heap.h> #include <heap.h>
...@@ -33,9 +33,6 @@ void *heap_alloc(void *hphandle, u32 size, u32 align) ...@@ -33,9 +33,6 @@ void *heap_alloc(void *hphandle, u32 size, u32 align)
char *block = NULL; char *block = NULL;
struct heap_object *obj = NULL; struct heap_object *obj = NULL;
gt_3trace(heap_debugmask, GT_6CLASS, "heap_alloc:\n"
"hphandle: %x, size: %x, align: %x \n",
hphandle, size, align);
BUG_ON(hphandle == NULL); BUG_ON(hphandle == NULL);
obj = (struct heap_object *)hphandle; obj = (struct heap_object *)hphandle;
...@@ -55,9 +52,6 @@ int heap_free(void *hphandle, void *block, u32 size) ...@@ -55,9 +52,6 @@ int heap_free(void *hphandle, void *block, u32 size)
struct heap_object *obj = NULL; struct heap_object *obj = NULL;
s32 retval = 0; s32 retval = 0;
gt_3trace(heap_debugmask, GT_6CLASS, "heap_free:\n"
"hphandle: %x, block: %x, size: %x \n",
hphandle, block, size);
BUG_ON(hphandle == NULL); BUG_ON(hphandle == NULL);
obj = (struct heap_object *)hphandle; obj = (struct heap_object *)hphandle;
...@@ -76,8 +70,6 @@ int heap_get_stats(void *hphandle, struct memory_stats *stats) ...@@ -76,8 +70,6 @@ int heap_get_stats(void *hphandle, struct memory_stats *stats)
struct heap_object *obj = NULL; struct heap_object *obj = NULL;
s32 retval = 0; s32 retval = 0;
gt_2trace(heap_debugmask, GT_6CLASS, "heap_get_stats:\n"
"hphandle: %x, stats: %x \n", hphandle, stats);
BUG_ON(hphandle == NULL); BUG_ON(hphandle == NULL);
BUG_ON(stats == NULL); BUG_ON(stats == NULL);
...@@ -98,9 +90,6 @@ int heap_get_extended_stats(void *hphandle, ...@@ -98,9 +90,6 @@ int heap_get_extended_stats(void *hphandle,
struct heap_object *obj = NULL; struct heap_object *obj = NULL;
s32 retval = 0; s32 retval = 0;
gt_2trace(heap_debugmask, GT_6CLASS,
"heap_get_extended_stats:\n"
"hphandle: %x, stats: %x \n", hphandle, stats);
BUG_ON(hphandle == NULL); BUG_ON(hphandle == NULL);
BUG_ON(stats == NULL); BUG_ON(stats == NULL);
......
...@@ -23,7 +23,6 @@ ...@@ -23,7 +23,6 @@
#include <linux/mutex.h> #include <linux/mutex.h>
#include <linux/slab.h> #include <linux/slab.h>
#include <gt.h>
#include <atomic_linux.h> #include <atomic_linux.h>
#include <multiproc.h> #include <multiproc.h>
#include <nameserver.h> #include <nameserver.h>
......
...@@ -24,9 +24,6 @@ ...@@ -24,9 +24,6 @@
#include <linux/bug.h> #include <linux/bug.h>
#include <linux/fs.h> #include <linux/fs.h>
/* Syslink headers */
#include <gt.h>
/* Module Headers */ /* Module Headers */
#include <messageq.h> #include <messageq.h>
#include <messageq_transportshm.h> #include <messageq_transportshm.h>
...@@ -255,10 +252,6 @@ int messageq_transportshm_ioctl(struct inode *inode, struct file *filp, ...@@ -255,10 +252,6 @@ int messageq_transportshm_ioctl(struct inode *inode, struct file *filp,
struct messageq_transportshm_cmd_args cargs; struct messageq_transportshm_cmd_args cargs;
unsigned long size; unsigned long size;
gt_4trace(curTrace, GT_ENTER, "messageq_transportshm_ioctl"
"inode: %x, filp: %x,\n cmd: %x, args: %x",
inode, filp, cmd, args);
if (_IOC_DIR(cmd) & _IOC_READ) if (_IOC_DIR(cmd) & _IOC_READ)
os_status = !access_ok(VERIFY_WRITE, uarg, _IOC_SIZE(cmd)); os_status = !access_ok(VERIFY_WRITE, uarg, _IOC_SIZE(cmd));
else if (_IOC_DIR(cmd) & _IOC_WRITE) else if (_IOC_DIR(cmd) & _IOC_WRITE)
...@@ -328,8 +321,10 @@ int messageq_transportshm_ioctl(struct inode *inode, struct file *filp, ...@@ -328,8 +321,10 @@ int messageq_transportshm_ioctl(struct inode *inode, struct file *filp,
os_status = -EFAULT; os_status = -EFAULT;
goto exit; goto exit;
} }
return os_status;
exit: exit:
gt_1trace(curTrace, GT_LEAVE, "messageq_transportshm_ioctl", os_status); printk(KERN_ERR "messageq_transportshm_ioctl failed: status = 0x%x\n",
os_status);
return os_status; return os_status;
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment