• Mark Gross's avatar
    USB: usb-skeleton leaking locks on open · f7294055
    Mark Gross authored
    This weekend I was hacking around with a trivial USB driver for talking
    to the boot load firmware of a USB Bit Whacker.  It's running the
    MicroChip Pic18 boot loader firmware and I'm putting together a flash
    program for writing new FW to the thing.
    
    Anyway in my use of the usb-skeleton.c as my starting point I discovered
    my test program was getting hung up after attempting to write a buffer.
    The application and driver where hung in a way that required me to
    reboot to get it to clean up so I could try again.
    
    It turned out the code path through skel_open can grap the driver's
    io_mutex lock and forget to release it.
    
    The following patch fixes the problem for me.
    Signed-off-by: default avatarMark Gross <mgross@linux.intel.com>
    Cc: Oliver Neukum <oliver@neukum.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    f7294055
usb-skeleton.c 13.1 KB