This fixes a race condition where the player was visible on the bus
with the MPRIS name, but did not implement MPRIS.

Note that we cannot hold the playlist lock while removing the callback,
since the callback function takes the playlist lock.

This is accessed with the playlock lock anyway.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

This fixes the following compilation error.

-----
  CC       os2/specific.lo
os2/specific.c: In function 'IPCHelperThread':
os2/specific.c:107:34: error: 'VLC_INPUT_OPTION_TRUSTED' undeclared (first use in this function)
                                  VLC_INPUT_OPTION_TRUSTED,
                                  ^
os2/specific.c:107:34: note: each undeclared identifier is reported only once for each function it appears in
-----
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

This fixes the following compilation error.

-----
  CC       demux/libts_plugin_la-ts.lo
demux/ts.c: In function 'EITCallBack':
demux/ts.c:3114:13: error: implicit declaration of function 'time' [-Werror=implicit-function-declaration]
             time_t timer = time( NULL );
             ^
demux/ts.c:3115:13: error: implicit declaration of function 'difftime' [-Werror=implicit-function-declaration]
             int64_t diff = difftime( mktime( localtime( &timer ) ),
             ^
demux/ts.c:3115:13: error: implicit declaration of function 'mktime' [-Werror=implicit-function-declaration]
demux/ts.c:3115:13: error: implicit declaration of function 'localtime' [-Werror=implicit-function-declaration]
demux/ts.c:3116:38: error: implicit declaration of function 'gmtime' [-Werror=implicit-function-declaration]
                                      mktime( gmtime( &timer ) ) );
                                      ^
-----
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>

Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>

This lead to a deadlock when attempting to pause an input that did not
support pausing.

This was inefficient and caused attachments from the meta engine or from
the slave demuxers to get lost.

Note that those attachments will still get lost later if the master
demuxer sets the metadata update flag (which affects the Ogg demuxer
only so far), or when adding a slave input.

All regressions introduced in e4673369.

Also improve error messages.

Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>
Fixed-by: Francois Cartegnie <fcvlcdev@free.fr>