Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

This commit add a deref-after-free bug.

This reverts commit 25cbae45.

Signed-off-by: Rafaël Carré <rafael.carre@gmail.com>

Signed-off-by: Rafaël Carré <rafael.carre@gmail.com>

assuming TAB_APPEND will know what to do with a NULL string ptr
as opposed to an undefined one.

Signed-off-by: Rémi Duraffort <ivoire@videolan.org>

If http-use-IE-proxy is enable, use Internet Explorer entered HTTP proxy server configuration for all URL. Don't take into account bypasses settings and auto configuration scripts.
Signed-off-by: Rémi Duraffort <ivoire@videolan.org>

indexed accesses and packing up repetetive free() calls. Also
some cosmetics. Should not add functional changes but should make
it a bit more readable.

This breaks our current Xlib XVideo and plain X11 outputs.
Qt4 would create an ARGB window for our embedded video. Then, the
Xlib plugins would raise BadMatch errors and VLC aborts. Starting
cairo-dock is an easy way to trigger this problem.
(With XCB plugins, we fail safe to OpenGL/GLX instead of crashing.)

We should instead handle ARGB visuals properly. But that would involve
more efforts, and would only enable plain X11, not XVideo anyway.

This should work around LP#416294.

This is ugly and not thread-safe. If you have a better idea, go ahead.
(cherry picked from commit c0ec5be56e71c273eef4faea8d927eeb3cbc7ec5)

N.B.: it seems swscale does not follow the RGB masks properly;
red and blue are swapped.