The initial value of the variable must be correct when the variables
lock is released after the variable was created. Hence we could not
release the lock between Insert() and InheritValue(). If we did, there
would be a race where another thread could see the variable with the
generic default value (0, "", 0., ...) instead of the inherited value.

So instead, we inherit the value in a temporary variable on the stack,
before we take the variables lock. Then we can create the variable with
the correct value without taking the lock for the duration of
InheritValue().

This adds overhead when an existing variable is re-created (i.e.
reference count is increased but no new variable is created). But it
dramatically reduces contention on the variables lock. More importantly,
it allows calling InheritValue() without the variables lock. So when we
fix InheritValue(), which is currently not thread-safe, we won't have
any problem with nested locking.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Here, the DSEnumCallback documentation seems wrong or misleading, it needs LPCWSTR with DirectSoundEnumerateW
http://msdn.microsoft.com/en-us/library/microsoft.directx_sdk.reference.dsenumcallback%28VS.85%29.aspxSigned-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Add an alias as "directsound"
Add the deprecated option
Add the change_restart_needed
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

InheritValue() is not thread-safe. It runs under the variable lock of
the object creating the new variabe. But it reads variables of parent
objects. This would require the variable lock of the parent object.

We still need to fix var_Create() with VLC_VAR_DOINHERIT.

If ALSA_DEFAULT cannot be opened, loop through all available alsa input devices.
(And if an alsa device was provided in the mrl but couldn't be opened, print the list of available alsa input devices in the debug output after the open error message.)

This reverts commit 29847260.
I'd rather have a stable lua api (besides, vlclua_gettext is already a noop).

This fullscreen controller is copied from the main window.
It can be activated in fullscreen mode either via the 'i' hotkey
 or mouse middle button.

This patch ensures we get the same behavior on Vista/Win7
 (new vout_display) as we get on WinXP (old vout output with directx)

Opacity used to work only on newly loaded skins, but failed to work from
skins restored from a previous session.

This fixes vlc hanging when closed via the popupmenu in the taskbar.

Signed-off-by: Pierre d'Herbemont <pdherbemont@free.fr>

Signed-off-by: Pierre d'Herbemont <pdherbemont@free.fr>