fixes #10125, #10199

This is superseded by a proper fix.
This reverts commit fa396d19.

This reverts commit c3bb23cd.

If Start() failed, IDirectSound_Release() was called twice.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net> with changes

Fix a crash occurring when CreateDSBufferPCM() fails in Start() and
afterwards Stop() uses uninitialized pointer values when releasing
objects.
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

NSFullScreenWindowMask is not defined here.

Defining the category to a nonexisting class is not allowed, as well as providing
an interface for this class without implementation.

libavutil does what we do already

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

No functional change.

close #10716

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

libavutil will always check for all CPU features that it understands,
even those VLC masked. Thus masking features provides no savings.

libavutil runs more tests than VLC. Depending on the platform and
operating system combination, libavutil is either as conservative or
more conservative than VLC. As such masking features provides no extra
safety.

So overall, GetVlcDspMask() is useless, at least nowadays.

Android ARM NEON seems controversial so it is kept for now.

Close #9645
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

And don't download by default.

Fix a crash when parsing subtitles. From the man page of sscanf:
"the next pointer must be a pointer to character array that is long
enough to hold the input sequence and the terminating null byte"
Signed-off-by: Ilkka Ollakka <ileoo@videolan.org>

This is based on similar initialisation as is already done in the
playlist_Create() function.
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Also set size only if it's > 0 (assume 0 is non-usable font-size).