Add rockbox's cover.jpg to the list of known files
Give the possibility to add a custom filename with --album-art-filename
Properly handle URIs on Win32 and other
Cleaner code

(cherry picked from commit 1cc1d3ab)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

This fixes a corner case:
A: rdlock -> OK
B: wrlock -> sleeps
A: rdlock -> dead lock

Signed-off-by: Laurent Aimar <fenrir@videolan.org>

(cherry picked from commit 3aa5a9f8)

This reverts commit 3d0ef016.

As agreed, the information loss is too important, even for sanitizing the ABI. And there are alternative solutions available.

Signed-off-by: Jean-Paul Saman <jean-paul.saman@m2x.nl>
(cherry picked from commit 2c1ccdbd)

Most if not all subscribers are using a fast asynchronous callback
internally anyway (at least Qt4 and libvlc do that). This was
redumdant and wasteful.

Parsing of a format string will anyway stop at the first nul, so there
is no point in having two nuls.

(cherry picked from commit 4054dd1f)

(cherry picked from commit 3709fb1e)

The code (with or without this patch) looks quite fishy though.
Fortunately, I do not understand Objective-C, so I can blindly assume
it is correct.

This gets rid of the blocking queued connection for non-modal errors,
which was causing deadlocks in the audio output

Pointed-out-by: Laurent Aimar

Signed-off-by: Rémi Duraffort <ivoire@videolan.org>