Add a few more lockings around other playlist data as well. We really need to redo all this stuff.
(cherry picked from commit 03071b8a)
Signed-off-by: Derk-Jan Hartman <hartman@videolan.org>

macosx: volume needs to be stored in absolute numbers instead of percentages. If you don't do this, the user will get a quite different noise experience...

Closes #2805

(cherry picked from commit 0c24ead9)
Signed-off-by: Derk-Jan Hartman <hartman@videolan.org>

Partial backport of [cc4f67fe]

A memleak in the handling of NSAnimation
(cherry picked from commit 9d7513ae)
Signed-off-by: Derk-Jan Hartman <hartman@videolan.org>

Use UDBZ instead of UDZO as disk-image format, which should save us about almost 20% of its previous size

This format isn't 10.3 compatible, but VLC isn't either, so we shouldn't care. Pointed by zacwest on the forums.
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

Those finer grained locks help the media_list_player.
(cherry picked from commit 6dbf7ce4)
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Patch by Kaloyan Kovachev
(cherry picked from commit 2d81a38b)

/me idiot.
(cherry picked from commit 4c2b6cc3)
Signed-off-by: Derk-Jan Hartman <hartman@videolan.org>

misc/mtime.c:59:18: warning: extra tokens at end of #ifdef directive
Grah, sorry about this, Apple parser doesn't see this as a problem, but other platforms do of course.
(cherry picked from commit 7d391a6d)
Signed-off-by: Derk-Jan Hartman <hartman@videolan.org>

Introduced in [5ead92ff], on PowerPC-based Macs this breaks the playback of a certain AVI and WMV files for reasons not fully understood. The commit was reverted for PPC macs in
* [49f3721c]
* [7786caa5]
but these commits were never applied to the master branch.
(cherry picked from commit c6ce6df8)
Signed-off-by: Derk-Jan Hartman <hartman@videolan.org>

Most of the time the module was still selected due to extension lookup.
It is also reported that avformat still is unstable when seeking mkv's
(cherry picked from commit eafaeb2c)
Signed-off-by: Derk-Jan Hartman <hartman@videolan.org>

(cherry picked from commit f8bc9414)
Signed-off-by: Derk-Jan Hartman <hartman@videolan.org>

"Adjustment and Effects, Synchronisation, Subtitles/Video, Speed of the subtitles, minus sign is not clickable" Spotted by Trax.
(cherry picked from commit 9cef9256)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Christophe Mutricy <xtophe@videolan.org>

Signed-off-by: Christophe Mutricy <xtophe@videolan.org>

Signed-off-by: Christophe Mutricy <xtophe@videolan.org>

A thank you to the Xbmc authors who had this fixed in their version of Martin Kahr's class.

Fixes a bug introduced on [795fa06c]
Closes #2794

(cherry picked from commit b01b54b0)
Signed-off-by: Rémi Duraffort <ivoire@videolan.org>

* initmethods returning nil. checks moved outside init.
* leaking module_config_get. Keep better track of those.
* spurious strdup
* leaked hotkeys NSMutableArray when resetting the preferences.

Introduced by [ca17039c]

According to x264 code, if it fails, it return NULL.
And with a first NULL parameter x264_encoder_headers() segfaults.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Note that "avformat{mux=mjpeg}" is also valid.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

When reading a file:// URL from an xspf entry, store the decoded file path; else store the unmodified URL

Always keep album art URLs always encoded and decode the path when needed
Interfaces & plugins only use file paths
Playlist core extract attachment:// URLs (from file meta data), http:// or other (from meta data fetchers like lua) and cache them to a file

Thanks to courmisch for clarification
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>