This reverts commit 3eeab0d3, reversing
changes made to 7079b91c.

This reverts commit 8d812e0a.

"Adjustment and Effects, Synchronisation, Subtitles/Video, Speed of the subtitles, minus sign is not clickable" Spotted by Trax.

It will allow hiding vout_thread_t fields.

It is prefered to use picture_NewFromFormat over picture_New (it may replace
it latter).

It is usefull to avoid reallocating pictures over and over.

 Becarefull, it is not yet thread safe as picture_t reference count
is not.
 I will change it when more work has been done on the vout.

contribs: enforce usage of gcc-4.2 instead of llvm-gcc-4.2 for libx264 to ensure proper linking on both PPC and x86 based Macs

Binary packages will need an update here.

Cosmetics: Remove need to (char*)"..." by making the target const, and replace a call to var_Get(bool) with var_GetBool.

Cosmetics, and pull finding the playlist sorting function back to top level. The meta_* functions are still wildly inefficient, though.

A thank you to the Xbmc authors who had this fixed in their version of Martin Kahr's class.
(cherry picked from commit 7157ad33)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit ced7fc2d)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Fixes a bug introduced on [795fa06c]
Closes #2794
(cherry picked from commit fc9987fa)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit e4bbb16b)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

* initmethods returning nil. checks moved outside init.
* leaking module_config_get. Keep better track of those.
* spurious strdup
* leaked hotkeys NSMutableArray when resetting the preferences.
(cherry picked from commit 27d84188)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit 5cbb5848)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Introduced by [ca17039c]
(cherry picked from commit c543a40d)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

According to x264 code, if it fails, it return NULL.
And with a first NULL parameter x264_encoder_headers() segfaults.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
(cherry picked from commit 77dea4ef)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Note that "avformat{mux=mjpeg}" is also valid.
(cherry picked from commit f69af253)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit 76084969)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

When reading a file:// URL from an xspf entry, store the decoded file path; else store the unmodified URL

Always keep album art URLs always encoded and decode the path when needed
Interfaces & plugins only use file paths
Playlist core extract attachment:// URLs (from file meta data), http:// or other (from meta data fetchers like lua) and cache them to a file

Thanks to courmisch for clarification
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
(cherry picked from commit a654d4a1)

(cherry picked from commit 1d3b0ce2)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit ca17039c)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit 1692e700)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit a037a08d)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit cbe99811)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>