Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc
Commits
dfa0e1e9
Commit
dfa0e1e9
authored
Sep 02, 2008
by
Pierre d'Herbemont
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
update: Make sure we don't leak.
This fix also a crash because of a non joined thread on Mac OS X.
parent
884122a7
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
10 additions
and
0 deletions
+10
-0
modules/gui/macosx/intf.m
modules/gui/macosx/intf.m
+2
-0
modules/gui/macosx/update.h
modules/gui/macosx/update.h
+2
-0
modules/gui/macosx/update.m
modules/gui/macosx/update.m
+5
-0
src/misc/update.c
src/misc/update.c
+1
-0
No files found.
modules/gui/macosx/intf.m
View file @
dfa0e1e9
...
...
@@ -672,6 +672,8 @@ static VLCMain *_o_sharedMainInstance = nil;
/* remove global observer watching for vout device changes correctly */
[[
NSNotificationCenter
defaultCenter
]
removeObserver
:
self
];
[
o_update
end
];
/* release some other objects here, because it isn't sure whether dealloc
* will be called later on */
...
...
modules/gui/macosx/update.h
View file @
dfa0e1e9
...
...
@@ -47,6 +47,8 @@
bool
b_checked
;
}
-
(
void
)
end
;
-
(
IBAction
)
download
:(
id
)
sender
;
-
(
IBAction
)
okay
:(
id
)
sender
;
-
(
IBAction
)
changeCheckUpdateOnStartup
:(
id
)
sender
;
...
...
modules/gui/macosx/update.m
View file @
dfa0e1e9
...
...
@@ -69,6 +69,11 @@ static VLCUpdate *_o_sharedInstance = nil;
return
_o_sharedInstance
;
}
-
(
void
)
end
{
if
(
p_u
)
update_Delete
(
p_u
);
}
-
(
void
)
awakeFromNib
{
/* we don't use - (BOOL)shouldCheckUpdateOnStartup because we don't want
...
...
src/misc/update.c
View file @
dfa0e1e9
...
...
@@ -1074,6 +1074,7 @@ void update_Delete( update_t *p_update )
assert
(
!
p_update
->
p_download
);
vlc_object_kill
(
p_update
->
p_check
);
vlc_thread_join
(
p_update
->
p_check
);
vlc_object_release
(
p_update
->
p_check
);
}
else
if
(
p_update
->
p_download
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment