Skip to content

V
vlc
Commit d768b02e authored by David Fuhrmann's avatar David Fuhrmann
Browse files
Options

macosx: fix checked state for extensions (close #14855)

parent 2a584bfb
Hide whitespace changes
Inline Side-by-side
Showing with 7 additions and 4 deletions
modules/gui/macosx/ExtensionsDialogProvider.m
View file @ d768b02e
...@@ -192,9 +192,9 @@ static void updateControlFromWidget(NSView *control, extension_widget_t *widget, ...@@ -192,9 +192,9 @@ static void updateControlFromWidget(NSView *control, extension_widget_t *widget,
{ {
assert([control isKindOfClass:[NSButton class]]); assert([control isKindOfClass:[NSButton class]]);
NSButton *button = (NSButton *)control; NSButton *button = (NSButton *)control;
if (!widget->psz_text) [button setTitle:toNSStr(widget->psz_text)];
break; if (widget->type == EXTENSION_WIDGET_CHECK_BOX)
[button setTitle:[NSString stringWithUTF8String:widget->psz_text]]; [button setState:widget->b_checked ? NSOnState : NSOffState];
break; break;
} }
case EXTENSION_WIDGET_DROPDOWN: case EXTENSION_WIDGET_DROPDOWN:
...@@ -342,7 +342,10 @@ static ExtensionsDialogProvider *_o_sharedInstance = nil; ...@@ -342,7 +342,10 @@ static ExtensionsDialogProvider *_o_sharedInstance = nil;
extension_widget_t *widget = [button widget]; extension_widget_t *widget = [button widget];
vlc_mutex_lock(&widget->p_dialog->lock); vlc_mutex_lock(&widget->p_dialog->lock);
extension_WidgetClicked(widget->p_dialog, widget); if (widget->type == EXTENSION_WIDGET_BUTTON)
extension_WidgetClicked(widget->p_dialog, widget);
else
widget->b_checked = [button state] == NSOnState;
vlc_mutex_unlock(&widget->p_dialog->lock); vlc_mutex_unlock(&widget->p_dialog->lock);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment