Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc
Commits
c8566c0a
Commit
c8566c0a
authored
Mar 26, 2012
by
Francois Cartegnie
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Qt: ConfigControl: enforce use of factory or non virtual class constructors
parent
35b05c47
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
22 additions
and
19 deletions
+22
-19
modules/gui/qt4/components/preferences_widgets.hpp
modules/gui/qt4/components/preferences_widgets.hpp
+22
-19
No files found.
modules/gui/qt4/components/preferences_widgets.hpp
View file @
c8566c0a
...
...
@@ -79,16 +79,6 @@ class ConfigControl : public QObject
{
Q_OBJECT
public:
ConfigControl
(
vlc_object_t
*
_p_this
,
module_config_t
*
_p_conf
,
QWidget
*
p
)
:
p_this
(
_p_this
),
p_item
(
_p_conf
)
{
widget
=
NULL
;
}
ConfigControl
(
vlc_object_t
*
_p_this
,
module_config_t
*
_p_conf
)
:
p_this
(
_p_this
),
p_item
(
_p_conf
)
{
widget
=
NULL
;
}
virtual
int
getType
()
const
=
0
;
const
char
*
getName
()
const
{
return
p_item
->
psz_name
;
}
QWidget
*
getWidget
()
const
{
return
widget
;
}
...
...
@@ -101,6 +91,16 @@ public:
QGridLayout
*
,
int
line
=
0
);
virtual
void
doApply
()
=
0
;
protected:
ConfigControl
(
vlc_object_t
*
_p_this
,
module_config_t
*
_p_conf
,
QWidget
*
p
)
:
p_this
(
_p_this
),
p_item
(
_p_conf
)
{
widget
=
NULL
;
}
ConfigControl
(
vlc_object_t
*
_p_this
,
module_config_t
*
_p_conf
)
:
p_this
(
_p_this
),
p_item
(
_p_conf
)
{
widget
=
NULL
;
}
vlc_object_t
*
p_this
;
module_config_t
*
p_item
;
QString
_name
;
...
...
@@ -119,13 +119,14 @@ class VIntConfigControl : public ConfigControl
{
Q_OBJECT
public:
virtual
int
getValue
()
const
=
0
;
virtual
int
getType
()
const
;
virtual
void
doApply
();
protected:
VIntConfigControl
(
vlc_object_t
*
a
,
module_config_t
*
b
,
QWidget
*
c
)
:
ConfigControl
(
a
,
b
,
c
)
{};
VIntConfigControl
(
vlc_object_t
*
a
,
module_config_t
*
b
)
:
ConfigControl
(
a
,
b
)
{};
virtual
int
getValue
()
const
=
0
;
virtual
int
getType
()
const
;
virtual
void
doApply
();
};
class
IntegerConfigControl
:
public
VIntConfigControl
...
...
@@ -236,13 +237,14 @@ class VFloatConfigControl : public ConfigControl
{
Q_OBJECT
public:
virtual
float
getValue
()
const
=
0
;
virtual
int
getType
()
const
;
virtual
void
doApply
();
protected:
VFloatConfigControl
(
vlc_object_t
*
a
,
module_config_t
*
b
,
QWidget
*
c
)
:
ConfigControl
(
a
,
b
,
c
)
{};
VFloatConfigControl
(
vlc_object_t
*
a
,
module_config_t
*
b
)
:
ConfigControl
(
a
,
b
)
{};
virtual
float
getValue
()
const
=
0
;
virtual
int
getType
()
const
;
virtual
void
doApply
();
};
class
FloatConfigControl
:
public
VFloatConfigControl
...
...
@@ -284,13 +286,14 @@ class VStringConfigControl : public ConfigControl
{
Q_OBJECT
public:
virtual
QString
getValue
()
const
=
0
;
virtual
int
getType
()
const
;
virtual
void
doApply
();
protected:
VStringConfigControl
(
vlc_object_t
*
a
,
module_config_t
*
b
,
QWidget
*
c
)
:
ConfigControl
(
a
,
b
,
c
)
{};
VStringConfigControl
(
vlc_object_t
*
a
,
module_config_t
*
b
)
:
ConfigControl
(
a
,
b
)
{};
virtual
QString
getValue
()
const
=
0
;
virtual
int
getType
()
const
;
virtual
void
doApply
();
};
class
StringConfigControl
:
public
VStringConfigControl
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment