playlist/item-ext.c: fixed off-by-one error causing a crash in ItemGetById

7df5cf2f · Sigmund Augdal Helberg · ed9d453a · 7df5cf2f
Commit 7df5cf2f authored Apr 15, 2005 by Sigmund Augdal Helberg
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

src/playlist/item-ext.c src/playlist/item-ext.c +1 -1

No files found.
--- a/src/playlist/item-ext.c
+++ b/src/playlist/item-ext.c
@@ -441,7 +441,7 @@ playlist_item_t *playlist_LockItemGetByPos( playlist_t *p_playlist, int i_pos )
 playlist_item_t * playlist_ItemGetById( playlist_t * p_playlist , int i_id )
 {
    int i, i_top, i_bottom;
-    i_bottom = 0; i_top = p_playlist->i_all_size;
+    i_bottom = 0; i_top = p_playlist->i_all_size - 1;
    i = i_top / 2;
    while( p_playlist->pp_all_items[i]->input.i_id != i_id &&
           i_top > i_bottom )