Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc
Commits
79d88eed
Commit
79d88eed
authored
Nov 15, 2012
by
Felix Paul Kühne
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
macosx: fixed objc string comparison error found by the clang static analyzer
this worked out of pure luck for the past 6 years
parent
93b8dfeb
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
4 deletions
+4
-4
modules/gui/macosx/wizard.m
modules/gui/macosx/wizard.m
+4
-4
No files found.
modules/gui/macosx/wizard.m
View file @
79d88eed
...
...
@@ -1097,7 +1097,7 @@ static VLCWizard *_o_sharedInstance = nil;
NSString
*
theEncapFormat
=
[[
o_encapFormats
objectAtIndex
:
[[
o_userSelections
objectForKey
:
@"encapFormat"
]
intValue
]]
objectAtIndex:
0
];
if
(
theEncapFormat
==
@"ps"
)
if
(
[
theEncapFormat
isEqualToString
:
@"ps"
]
)
theEncapFormat
=
@"mpg"
;
/* look whether we need to process multiple items or not.
...
...
@@ -1483,7 +1483,7 @@ static VLCWizard *_o_sharedInstance = nil;
[
o_sap_option
appendFormat
:
@"sap,name=
\"
%@
\"
"
,
[
o_userSelections
objectForKey
:
@"sapText"
]];
}
if
([[
o_strmgMthds
objectAtIndex
:
[[
o_userSelections
objectForKey
:
@"stmgMhd"
]
intValue
]]
objectAtIndex
:
0
]
==
@"rtp"
)
if
([[
[
o_strmgMthds
objectAtIndex
:
[[
o_userSelections
objectForKey
:
@"stmgMhd"
]
intValue
]]
objectAtIndex
:
0
]
isEqualToString
:
@"rtp"
]
)
{
/* RTP is no access out, but a stream out module */
[
o_opts_string
appendFormat
:
...
...
@@ -1507,7 +1507,7 @@ static VLCWizard *_o_sharedInstance = nil;
else
{
/* no SAP, just streaming */
if
([[
o_strmgMthds
objectAtIndex
:
[[
o_userSelections
objectForKey
:
@"stmgMhd"
]
intValue
]]
objectAtIndex
:
0
]
==
@"rtp"
)
if
([[
[
o_strmgMthds
objectAtIndex
:
[[
o_userSelections
objectForKey
:
@"stmgMhd"
]
intValue
]]
objectAtIndex
:
0
]
isEqualToString
:
@"rtp"
]
)
{
/* RTP is different from the other protocols, as it isn't provided through an access out module anymore */
[
o_opts_string
appendFormat
:
...
...
@@ -1858,7 +1858,7 @@ static VLCWizard *_o_sharedInstance = nil;
NSString
*
theEncapFormat
=
[[
o_encapFormats
objectAtIndex
:
[[
o_userSelections
objectForKey
:
@"encapFormat"
]
intValue
]]
objectAtIndex:
0
];
if
(
theEncapFormat
!=
@"ps"
)
if
(
!
[
theEncapFormat
isEqualToString
:
@"ps"
]
)
[
saveFilePanel
setAllowedFileTypes
:
[
NSArray
arrayWithObject
:
theEncapFormat
]];
else
[
saveFilePanel
setAllowedFileTypes
:
[
NSArray
arrayWithObject
:
@"mpg"
]];
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment