Skip to content

V
vlc
Commit 6edb730d authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont
Browse files
Options

Ignore insecure HTTP redirection to non HTTP protocol

parent 1a8f715c
Hide whitespace changes
Inline Side-by-side
Showing with 9 additions and 1 deletion
modules/access/http.c
View file @ 6edb730d
...@@ -322,6 +322,15 @@ static int Open( vlc_object_t *p_this ) ...@@ -322,6 +322,15 @@ static int Open( vlc_object_t *p_this )
msg_Dbg( p_access, "redirection to %s", p_sys->psz_location ); msg_Dbg( p_access, "redirection to %s", p_sys->psz_location );
/* Do not accept redirection outside of HTTP works */
if( strncmp( p_sys->psz_location, "http", 4 )
|| ( ( p_sys->psz_location[4] != ':' ) /* HTTP */
&& strncmp( p_sys->psz_location + 4, "s:", 2 ) /* HTTP/SSL */ ) )
{
msg_Err( p_access, "insecure redirection ignored" );
goto error;
}
p_playlist = vlc_object_find( p_access, VLC_OBJECT_PLAYLIST, p_playlist = vlc_object_find( p_access, VLC_OBJECT_PLAYLIST,
FIND_ANYWHERE ); FIND_ANYWHERE );
if( !p_playlist ) if( !p_playlist )
...@@ -874,7 +883,6 @@ static int Request( access_t *p_access, int64_t i_tell ) ...@@ -874,7 +883,6 @@ static int Request( access_t *p_access, int64_t i_tell )
if( p_sys->b_proxy ) if( p_sys->b_proxy )
{ {
/* FIXME: support SSL proxies */
if( p_sys->url.psz_path ) if( p_sys->url.psz_path )
{ {
net_Printf( VLC_OBJECT(p_access), p_sys->fd, NULL, net_Printf( VLC_OBJECT(p_access), p_sys->fd, NULL,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment