cache: missing error handling and leak on error

4dc5e6b3 · Rémi Denis-Courmont · ccc530cd · 4dc5e6b3
Commit 4dc5e6b3 authored Apr 25, 2015 by Rémi Denis-Courmont
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

src/modules/cache.c src/modules/cache.c +4 -1

No files found.
--- a/src/modules/cache.c
+++ b/src/modules/cache.c
@@ -217,6 +217,8 @@ error:
 static module_t *CacheLoadModule (FILE *file)
 {
    module_t *module = vlc_module_create (NULL);
+    if (unlikely(module == NULL))
+        return NULL;
    /* Load additional infos */
    LOAD_STRING(module->psz_shortname);
@@ -274,7 +276,8 @@ static module_t *CacheLoadModule (FILE *file)
    return module;
 error:
-    return NULL; /* FIXME: leaks */
+    vlc_module_destroy(module);
+    return NULL;
 }
 /**