Commit 47d7b5c0 authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont

XCB/XVideo: reject hardware surfaces for the time being

The core cannot blend subpictures to hardware surfaces. In principles,
blending could be performed post chroma conversion, but this is not
supported by the video output wrapper so far.
parent 3c0a0661
...@@ -374,6 +374,14 @@ static int Open (vlc_object_t *obj) ...@@ -374,6 +374,14 @@ static int Open (vlc_object_t *obj)
if (!var_InheritBool (obj, "overlay")) if (!var_InheritBool (obj, "overlay"))
return VLC_EGENERIC; return VLC_EGENERIC;
else
{ /* NOTE: Reject hardware surface formats. Blending would break. */
const vlc_chroma_description_t *chroma =
vlc_fourcc_GetChromaDescription(vd->source.i_chroma);
if (chroma != NULL && chroma->plane_count == 0)
return VLC_EGENERIC;
}
p_sys = malloc (sizeof (*p_sys)); p_sys = malloc (sizeof (*p_sys));
if (p_sys == NULL) if (p_sys == NULL)
return VLC_ENOMEM; return VLC_ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment