Skip to content

V
vlc
Commit 471fa3a8 authored by Derk-Jan Hartman's avatar Derk-Jan Hartman
Browse files
Options

Fix potential static array overflow (CID 40 and 192)

parent 6357ef21
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 4 deletions
modules/demux/ps.h
View file @ 471fa3a8
...@@ -344,10 +344,10 @@ static inline int ps_pkt_parse_system( block_t *p_pkt, ps_psm_t *p_psm, ...@@ -344,10 +344,10 @@ static inline int ps_pkt_parse_system( block_t *p_pkt, ps_psm_t *p_psm,
/* Parse a PES (and skip i_skip_extra in the payload) */ /* Parse a PES (and skip i_skip_extra in the payload) */
static inline int ps_pkt_parse_pes( block_t *p_pes, int i_skip_extra ) static inline int ps_pkt_parse_pes( block_t *p_pes, int i_skip_extra )
{ {
uint8_t header[30]; uint8_t header[34];
unsigned int i_skip = 0; unsigned int i_skip = 0;
memcpy( header, p_pes->p_buffer, __MIN( p_pes->i_buffer, 30 ) ); memcpy( header, p_pes->p_buffer, __MIN( p_pes->i_buffer, 34 ) );
switch( header[3] ) switch( header[3] )
{ {
......
modules/demux/ts.c
View file @ 471fa3a8
...@@ -1664,7 +1664,7 @@ static void PIDClean( es_out_t *out, ts_pid_t *pid ) ...@@ -1664,7 +1664,7 @@ static void PIDClean( es_out_t *out, ts_pid_t *pid )
static void ParsePES( demux_t *p_demux, ts_pid_t *pid ) static void ParsePES( demux_t *p_demux, ts_pid_t *pid )
{ {
block_t *p_pes = pid->es->p_pes; block_t *p_pes = pid->es->p_pes;
uint8_t header[30]; uint8_t header[34];
int i_pes_size = 0; int i_pes_size = 0;
int i_skip = 0; int i_skip = 0;
mtime_t i_dts = -1; mtime_t i_dts = -1;
...@@ -1679,7 +1679,7 @@ static void ParsePES( demux_t *p_demux, ts_pid_t *pid ) ...@@ -1679,7 +1679,7 @@ static void ParsePES( demux_t *p_demux, ts_pid_t *pid )
pid->es->pp_last = &pid->es->p_pes; pid->es->pp_last = &pid->es->p_pes;
/* FIXME find real max size */ /* FIXME find real max size */
i_max = block_ChainExtract( p_pes, header, 30 ); i_max = block_ChainExtract( p_pes, header, 34 );
if( header[0] != 0 || header[1] != 0 || header[2] != 1 ) if( header[0] != 0 || header[1] != 0 || header[2] != 1 )
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment