Commit 463555cb authored by Pierre Souchay's avatar Pierre Souchay Committed by Jean-Baptiste Kempf

ASX ads behaviour

When the first entry is read and has a clientskip attribute, It keeps a
backup of the playlist entry for later use. If another entry exists
without clientskip attribute, the backup will be discarded.

When finished parsing, we search for a backup, if found, we add it (it
means we did not find any entry).
parent 8f9b242f
...@@ -291,6 +291,10 @@ static int Demux( demux_t *p_demux ) ...@@ -291,6 +291,10 @@ static int Demux( demux_t *p_demux )
psz_parse = strcasestr( psz_parse, ">" ); psz_parse = strcasestr( psz_parse, ">" );
/* counter for single ad item */
input_item_t *uniq_entry_ad_backup = NULL;
int i_inserted_entries = 0;
while( psz_parse && ( psz_parse = strcasestr( psz_parse, "<" ) ) ) while( psz_parse && ( psz_parse = strcasestr( psz_parse, "<" ) ) )
{ {
if( !strncasecmp( psz_parse, "<!--", 4 ) ) if( !strncasecmp( psz_parse, "<!--", 4 ) )
...@@ -500,11 +504,10 @@ static int Demux( demux_t *p_demux ) ...@@ -500,11 +504,10 @@ static int Demux( demux_t *p_demux )
msg_Err( p_demux, "entry without href?" ); msg_Err( p_demux, "entry without href?" );
continue; continue;
} }
/* An skip entry is an ad only if other entries exist without skip */
if( p_sys->b_skip_ads && b_skip_entry ) if( p_sys->b_skip_ads && b_skip_entry && i_inserted_entries != 0 )
{ {
char *psz_current_input_name = input_item_GetName( p_current_input ); char *psz_current_input_name = input_item_GetName( p_current_input );
msg_Dbg( p_demux, "skipped entry %d %s (%s)", msg_Dbg( p_demux, "skipped entry %d %s (%s)",
i_entry_count, i_entry_count,
( psz_title_entry ? psz_title_entry : psz_current_input_name ), psz_href ); ( psz_title_entry ? psz_title_entry : psz_current_input_name ), psz_href );
...@@ -552,8 +555,23 @@ static int Demux( demux_t *p_demux ) ...@@ -552,8 +555,23 @@ static int Demux( demux_t *p_demux )
if( psz_copyright_entry ) input_item_SetCopyright( p_entry, psz_copyright_entry ); if( psz_copyright_entry ) input_item_SetCopyright( p_entry, psz_copyright_entry );
if( psz_moreinfo_entry ) input_item_SetURL( p_entry, psz_moreinfo_entry ); if( psz_moreinfo_entry ) input_item_SetURL( p_entry, psz_moreinfo_entry );
if( psz_abstract_entry ) input_item_SetDescription( p_entry, psz_abstract_entry ); if( psz_abstract_entry ) input_item_SetDescription( p_entry, psz_abstract_entry );
input_item_AddSubItem( p_current_input, p_entry );
vlc_gc_decref( p_entry ); i_inserted_entries++;
if( p_sys->b_skip_ads && b_skip_entry )
{
// We put the entry as a backup for unique ad case
uniq_entry_ad_backup = p_entry;
}
else
{
if( uniq_entry_ad_backup != NULL )
{
uniq_entry_ad_backup = NULL;
vlc_gc_decref( uniq_entry_ad_backup );
}
input_item_AddSubItem( p_current_input, p_entry );
vlc_gc_decref( p_entry );
}
} }
free( psz_current_input_name ); free( psz_current_input_name );
} }
...@@ -727,6 +745,13 @@ static int Demux( demux_t *p_demux ) ...@@ -727,6 +745,13 @@ static int Demux( demux_t *p_demux )
} }
else psz_parse++; else psz_parse++;
} }
if ( uniq_entry_ad_backup != NULL )
{
msg_Dbg( p_demux, "added unique entry even if ad");
/* If ASX contains a unique entry, we add it, it is probably not an ad */
input_item_AddSubItem( p_current_input, uniq_entry_ad_backup );
vlc_gc_decref( uniq_entry_ad_backup);
}
#if 0 #if 0
/* FIXME Unsupported elements */ /* FIXME Unsupported elements */
PARAM PARAM
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment