auhal: add missing bounds checking (close #10110)

4598d6ca · Felix Paul Kühne · 061c07bd · 4598d6ca
Commit 4598d6ca authored Dec 26, 2013 by Felix Paul Kühne
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 3 deletions

modules/audio_output/auhal.c modules/audio_output/auhal.c +5 -3

No files found.
--- a/modules/audio_output/auhal.c
+++ b/modules/audio_output/auhal.c
@@ -1445,9 +1445,11 @@ static OSStatus RenderCallbackAnalog(vlc_object_t *p_obj,
    } else {
        int32_t bytesToCopy = __MIN(bytesRequested, availableBytes);

-        memcpy(targetBuffer, buffer, bytesToCopy);
-        TPCircularBufferConsume(&p_sys->circular_buffer, bytesToCopy);
-        ioData->mBuffers[0].mDataByteSize = bytesToCopy;
+        if (likely(bytesToCopy > 0)) {
+            memcpy(targetBuffer, buffer, bytesToCopy);
+            TPCircularBufferConsume(&p_sys->circular_buffer, bytesToCopy);
+            ioData->mBuffers[0].mDataByteSize = bytesToCopy;
+        }
    }

    vlc_cond_signal(&p_sys->cond);