Commit 356fafa5 authored by Rémi Duraffort's avatar Rémi Duraffort

Fix potential buffer overflow (CID 191)

parent eeaa54cf
...@@ -93,8 +93,11 @@ int osd_parser_simpleOpen( vlc_object_t *p_this ) ...@@ -93,8 +93,11 @@ int osd_parser_simpleOpen( vlc_object_t *p_this )
/* NULL terminate before asking the length of path[] */ /* NULL terminate before asking the length of path[] */
path[PATH_MAX-1] = '\0'; path[PATH_MAX-1] = '\0';
i_len = strlen(&path[0]); i_len = strlen(&path[0]);
if( i_len == PATH_MAX ) /* Protect against buffer overflow:
i_len--; /* truncate to prevent buffer overflow */ * max index is PATH_MAX-1 and we increment by 1 after
* so PATH_MAX-2 is the bigest we can have */
if( i_len > PATH_MAX - 2 )
i_len = PATH_MAX - 2;
#if defined(WIN32) || defined(UNDER_CE) #if defined(WIN32) || defined(UNDER_CE)
if( (i_len > 0) && path[i_len] != '\\' ) if( (i_len > 0) && path[i_len] != '\\' )
path[i_len] = '\\'; path[i_len] = '\\';
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment