Skip to content

V
vlc
Commit 30dbe16a authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont
Browse files
Options

XCB/X11: fix long-standing massive leak on error

parent 776fb1cb
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 2 deletions
modules/video_output/xcb/x11.c
View file @ 30dbe16a
...@@ -406,13 +406,15 @@ static picture_pool_t *Pool (vout_display_t *vd, unsigned requested_count) ...@@ -406,13 +406,15 @@ static picture_pool_t *Pool (vout_display_t *vd, unsigned requested_count)
break; break;
} }
} }
xcb_flush (sys->conn);
if (count == 0) if (count == 0)
return NULL; return NULL;
sys->pool = picture_pool_New (count, pic_array); sys->pool = picture_pool_New (count, pic_array);
/* TODO release picture resources if NULL */ if (unlikely(sys->pool == NULL))
xcb_flush (sys->conn); while (count > 0)
picture_Release(pic_array[--count]);
return sys->pool; return sys->pool;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment