Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc
Commits
2b50f07b
Commit
2b50f07b
authored
Mar 04, 2009
by
Rémi Denis-Courmont
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove invalid VOUT_REPARENT uses
as discussed^Wmonologued on the mailing list.
parent
dd70e014
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
8 additions
and
35 deletions
+8
-35
modules/gui/maemo/maemo.c
modules/gui/maemo/maemo.c
+1
-9
modules/gui/skins2/src/vlcproc.cpp
modules/gui/skins2/src/vlcproc.cpp
+3
-10
src/control/media_player.c
src/control/media_player.c
+0
-7
src/control/video.c
src/control/video.c
+4
-9
No files found.
modules/gui/maemo/maemo.c
View file @
2b50f07b
...
...
@@ -249,15 +249,7 @@ static void Run( intf_thread_t *p_intf )
var_DelCallback
(
p_intf
->
p_sys
->
p_playlist
,
"activity"
,
activity_cb
,
p_intf
);
// Asking the vout to close
vout_thread_t
*
p_vout
=
p_intf
->
p_sys
->
p_vout
;
if
(
p_vout
)
{
vout_Control
(
p_vout
,
VOUT_REPARENT
,
0
);
vlc_object_release
(
p_vout
);
}
assert
(
!
p_intf
->
p_sys
->
p_vout
);
/* too late */
gtk_object_destroy
(
GTK_OBJECT
(
window
)
);
}
...
...
modules/gui/skins2/src/vlcproc.cpp
View file @
2b50f07b
...
...
@@ -196,15 +196,12 @@ VlcProc::~VlcProc()
var_DelCallback
(
getIntf
(),
"skin-to-load"
,
onSkinToLoad
,
this
);
}
#include <assert.h>
void
VlcProc
::
registerVoutWindow
(
void
*
pVoutWindow
)
{
m_handleSet
.
insert
(
pVoutWindow
);
// Reparent the vout window
if
(
m_pVout
)
{
vout_Control
(
m_pVout
,
VOUT_REPARENT
,
0
);
}
assert
(
!
m_pVout
);
}
...
...
@@ -216,11 +213,7 @@ void VlcProc::unregisterVoutWindow( void *pVoutWindow )
void
VlcProc
::
dropVout
()
{
if
(
m_pVout
)
{
vout_Control
(
m_pVout
,
VOUT_REPARENT
,
0
);
m_pVout
=
NULL
;
}
assert
(
!
m_pVout
);
}
...
...
src/control/media_player.c
View file @
2b50f07b
...
...
@@ -764,7 +764,6 @@ void libvlc_media_player_set_drawable( libvlc_media_player_t *p_mi,
libvlc_exception_t
*
p_e
)
{
input_thread_t
*
p_input_thread
;
vout_thread_t
*
p_vout
=
NULL
;
p_mi
->
drawable
.
xid
=
drawable
;
...
...
@@ -779,12 +778,6 @@ void libvlc_media_player_set_drawable( libvlc_media_player_t *p_mi,
return
;
}
p_vout
=
vlc_object_find
(
p_input_thread
,
VLC_OBJECT_VOUT
,
FIND_CHILD
);
if
(
p_vout
)
{
vout_Control
(
p_vout
,
VOUT_REPARENT
,
drawable
);
vlc_object_release
(
p_vout
);
}
vlc_object_release
(
p_input_thread
);
}
...
...
src/control/video.c
View file @
2b50f07b
...
...
@@ -5,7 +5,7 @@
*
* $Id$
*
* Authors: Cl
�
ent Stenac <zorglub@videolan.org>
* Authors: Cl
ém
ent Stenac <zorglub@videolan.org>
* Filippo Carone <littlejohn@videolan.org>
* Jean-Paul Saman <jpsaman _at_ m2x _dot_ nl>
* Damien Fouilleul <damienf a_t videolan dot org>
...
...
@@ -190,14 +190,9 @@ int libvlc_media_player_has_vout( libvlc_media_player_t *p_mi,
int
libvlc_video_reparent
(
libvlc_media_player_t
*
p_mi
,
libvlc_drawable_t
d
,
libvlc_exception_t
*
p_e
)
{
vout_thread_t
*
p_vout
=
GetVout
(
p_mi
,
p_e
);
if
(
p_vout
)
{
vout_Control
(
p_vout
,
VOUT_REPARENT
,
d
);
vlc_object_release
(
p_vout
);
}
return
0
;
(
void
)
p_mi
;
(
void
)
d
;
libvlc_exception_raise
(
p_e
,
"Reparenting not supported"
);
return
-
1
;
}
void
libvlc_video_resize
(
libvlc_media_player_t
*
p_mi
,
int
width
,
int
height
,
libvlc_exception_t
*
p_e
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment