Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc
Commits
18f598fb
Commit
18f598fb
authored
May 10, 2008
by
Rafaël Carré
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove misleading comment - correct NEWS
parent
12e13887
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
0 additions
and
21 deletions
+0
-21
NEWS
NEWS
+0
-2
modules/video_output/x11/xcommon.c
modules/video_output/x11/xcommon.c
+0
-19
No files found.
NEWS
View file @
18f598fb
...
...
@@ -7,8 +7,6 @@ Security updates:
Various bugfixes:
* Fixed various memory leaks, improving stability when running as a server
* The 'Always on Top' setting is automatically disabled in fullscreen mode
(Win32 only)
* Fix compilation with recent versions of FFmpeg
* Correctly parses SAP announcements from MPEG-TS
* Fix AAC resampling
...
...
modules/video_output/x11/xcommon.c
View file @
18f598fb
...
...
@@ -888,25 +888,6 @@ static int ManageVideo( vout_thread_t *p_vout )
/* Update the object variable and trigger callback */
val
.
b_bool
=
!
p_vout
->
b_fullscreen
;
/*
* FIXME FIXME FIXME FIXME: EXPLICIT HACK.
* On the one hand, we cannot hold the lock while triggering a
* callback, as it causes a deadlock with video-on-top handling.
* On the other hand, we have to lock while triggering the
* callback to:
* 1/ make sure video-on-top remains in sync with fullscreen
* (i.e. unlocking creates a race condition if fullscreen is
* switched on and off VERY FAST).
* 2/ avoid possible corruption bugs if another thread gets the
* mutex and modifies our data in-between.
*
* This is obviously contradictory. Correct solutions may include:
* - putting the fullscreen NAND video-on-top logic out of libvlc,
* back into the video output plugins (ugly code duplication...),
* - serializing fullscreen and video-on-top handling properly
* instead of doing it via the fullscreen callback. That's got to
* be the correct one.
*/
#ifdef MODULE_NAME_IS_xvmc
xvmc_context_reader_unlock
(
&
p_vout
->
p_sys
->
xvmc_lock
);
#endif
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment