Commit 0ac31c77 authored by Jean-Paul Saman's avatar Jean-Paul Saman

Turn comment into error message.

parent ed58d07d
...@@ -509,16 +509,28 @@ STDMETHODIMP VLCControl::toggleMute(void) ...@@ -509,16 +509,28 @@ STDMETHODIMP VLCControl::toggleMute(void)
STDMETHODIMP VLCControl::setVariable(BSTR name, VARIANT value) STDMETHODIMP VLCControl::setVariable(BSTR name, VARIANT value)
{ {
/** setVariable() is an unsafe interface because of security libvlc_instance_t* p_libvlc;
implications it has and is thus removed. */ HRESULT result = _p_instance->getVLC(&p_libvlc);
return E_INVALIDARG; if( SUCCEEDED(result) )
{
_p_instance->setErrorInfo(IID_IVLCControl,
"setVariable() is an unsafe interface to use. "
"It has been removed because of security implications." );
}
return E_FAIL;
}; };
STDMETHODIMP VLCControl::getVariable(BSTR name, VARIANT *value) STDMETHODIMP VLCControl::getVariable(BSTR name, VARIANT *value)
{ {
/** getVariable() is an unsafe interface because of security libvlc_instance_t* p_libvlc;
implications it has and is thus removed. */ HRESULT result = _p_instance->getVLC(&p_libvlc);
return E_INVALIDARG; if( SUCCEEDED(result) )
{
_p_instance->setErrorInfo(IID_IVLCControl,
"getVariable() is an unsafe interface to use. "
"It has been removed because of security implications." );
}
return E_FAIL;
}; };
void VLCControl::FreeTargetOptions(char **cOptions, int cOptionCount) void VLCControl::FreeTargetOptions(char **cOptions, int cOptionCount)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment