Signed-off-by: Jean-Baptiste Kempf <jb@sasmira.jbkempf.com>

This reverts commit 866faad6.

    module_t **list, *module;

    list = module_list_get (NULL);
    if (!list)
        return NULL;

    for (size_t i = 0; (module = list[i]) != NULL; i++)
                        ^^^^^^^^
I think this needs no more comment.

If module_find() does not find the requested module it would return an uninitialized pointer. This made VLC webplugin crash under MacOS X. Thus make sure to initialize it properly to NULL.

(I would not be surprised if the bug were in the VLC plugin though)

and fixed a small typo

macosx: re-arranged the audio and video menus to look similar to the Qt4 interface. Additionally, implemented an 'Open File...' item in the subtitles-submenu

macosx: implemented saving of the debug log as RTFD and slightly extended the catcher for outdated OS X versions.

Fixes #2517

It is related to #1122 and #1848.

Fixed by Pierre Ynard

This is a bit ugly but it fixes two race conditions:
 - loading plugins while another thread is initializing,
 - using the bank when the first thread has not completed loading plugins.

Unfortunately, there is still a small race when module_need() calls
AllocatePlugin(). It really should not -need to- do that, but the fix would
be quite invasive. We would basically need to store plugin callbacks by names
rather than function pointers. Then the module descriptors would be fully
serializable, so we would not need to re-describe plugins when loading their
shared object. That would also fix the last known corruption bug in the plugins
cache.

If we ever to reintroduce builtin modules, we anyway would need to
rewrite that part.