macosx: make sure the interface doesn't leak any inputs. fixes crashes on quit after adding a file to the playlist
(cherry picked from commit cf8441a23c17e1f17feedfd8681f0d846cb7d19b)

Especially this fixes validation for audio and playback menus.
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>
(cherry picked from commit a6fcfb77)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

macosx: move VLCFSPanel from VLCControls to VLCMainWindow since its the only class which should know about it

macosx: remove 2 interface update timers (2 threads), 1 additional interface update thread and replaced everything by callbacks

aka if you scroll to the right, you want the movie to skip to the right, etc.

this also prepares a mainwindow object and includes some clean-up

This is a first step to re-organize the interface, more to come

clean up here and there

minor functional changes only

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

macosx: fixed disappearing repeat button images introduced in [8f79caa3e4b56c73c719bfa7c444cccbf203aa19]

Closes #4886

The thread are already created with the right priority. If not, then
vlc_clone() should be fixed instead.
Also, the vlc_thread_set_priority() calls on the main interface thread
seem bogus, as the target thread is dedicated to monitor the libvlc
death and is not the main running thread.

git failed to apply the entire patch, sorry for the noise
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

No functional changes. Some more can't be replaced yet, as we still support 10.5

The memory usage is already there anyway. However, this increases the
code size a little, especially on 32-bits platforms.

N.B.: helper getter functions are still 32-bits until further change.
So are configuration items.

It reduces the number of executed vlc_object_find.
Some macosx calls have been commented out.

legacy macosx intf: make sure we display the right playback button graphic when drawing the video window

pl_Hold() assumed the playlist was already created.
pl_Release() does not solve any problem. Playlist synchronization is
done with the playlist lock, while playlist deletion must anyway be done
after all interfaces, services and other threads are joined.

Close #1122
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

Signed-off-by: Pierre d'Herbemont <pdherbemont@free.fr>

gui/macosx: try a fix of validateMenuItem: that avoid to fail on __vlc_object_release() assertion (internals->i_children==0).
Signed-off-by: Pierre d'Herbemont <pdherbemont@free.fr>

Should be backported.

(cherry picked from commit 79f751ebce51f32100f4f78e23d708a33ad373f2)
Signed-off-by: Derk-Jan Hartman <hartman@videolan.org>

(cherry picked from commit 5cbb5848e90522556a838ccf04646727fed10cc9)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit 1692e7000a5639bb70d1d48b761ee40707ddc560)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit a037a08d58e5b97af4ec09071818126fd581b27f)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit bc3883a52ee35d2d118f8a7c43093faa253cc0b4)

(cherry picked from commit 02b581e1dc54e8fe7c3ca6d24528539fd996ac13)