Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

clean up here and there

no functional changes

minor functional changes only

Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

Win32 spawns its own console so this is irrelevant

Windows still uses the oldrc interface (which is not aliased as cli).
This reverts commit e1eccb1f.

This is better than second-guessing module_need().

*cough* *cough*
There is a lot of images/ressource to remove, IMVHO

This patch makes some minor adjustments to the UI operation.

1) Add VLC Icons
2) Re-arrange Viewer / Library windows
3) Re-define some button names
4) Change some icons to improve clairity
5) Long press on Prev / Next buttons now seek back / forward

More to come later, including EQ, VLM UI, Maybe Mosaic.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

Modules list was intended for plain static module names. It does not
work right for most SD plugins, including:
 - LUA (dependent on string chain),
 - udev (submodules),
 - media directories (submodules).

It works but is totally useless for those plugins that are fast,
including XCB screen capture and Windows optical drives.

For network-based discovery and MTP, it could be used to prefetch
items. But this is not necessarily a good idea as it sends extra
network traffic and consumes memory even when the services discovery
is not used. Furthermore, podcast can prevent Qt4 and Skins2 UI from
starting, as it depends on HTTP which depends on libproxy which
depends on Xlib.

The biggest landmark of thread-unsafety.

With the introduction, initially for LUA SD, of the chain syntax to
the services discovery, there is no way to canonicalize the name of
a services discovery object. Thus, they cannot be compared reliably,
and therefore, playlist_IsServicesDiscoveryLoaded() does not operate
correctly. I won't remove it today because too many interfaces call it.
But you should know that this function does _not_ actually work, and I
see no way to fix it (other than remove LUA SD).

Futhermore, this function is fundamentally prone to a race condition,
when it is used to toggle an SD (this is admittedly a minor problem).