The problem came from my misreading of the API
This commit also fix potential misunderstanding by simplifying it further

2.3.4 is the unstable branch, as not indicated on the download page
This reverts commit cbac72de.

Fix compilation with external opencdk

Avoid an infinite loop for this case too (only 3 tries to connect, then abort)

Signed-off-by: Meuuh the cow

input: Split Init() into multiple subfunctions to try to isolate the different part of the function.

This improves readability a lot and prevent us from reinventing the wheel.

Removed nasm in favour of yasm for Darwin-x86. Note that yasm isn't build on PowerPC-based Macs because it's not needed.

Removed nasm from the contribs and changed the build behaviour for yasm: it's only compiled on Intel-based Macs as PPC-based Macs don't need it.

Don't use the export things in taglib as we don't need it and it's buggy

Also fix Distributions gitignore.

Move ppsz_input_state[] to modules/control/rc.c because it is the only user of this variable. This silences a lot of warning messages.

Don't compile dynamicoverlay when there is no POSIX shared memory support on the system. Use VLC_UNUSED() iso (void)().

Rename LoadImage() to blendbench_LoadImage() because of naming conflicts with Windows API and small cleanup/malloc checks.

Signed-off-by: Pierre d'Herbemont <pdherbemont@videolan.org>

assertions in release builds