Rename linked_with_a_crap_library_which_uses_atexit()

In several cases, it is not used because of atexit().

include/vlc_plugin.h

@@ -226,7 +226,7 @@ enum vlc_module_properties
      || vlc_module_set (p_submodule, VLC_MODULE_CB_CLOSE, deactivate)) \
         goto error;
 
-#define linked_with_a_crap_library_which_uses_atexit( ) \
+#define cannot_unload_broken_library( ) \
     if (vlc_module_set (p_submodule, VLC_MODULE_NO_UNLOAD)) \
         goto error;
 

modules/gui/macosx/macosx.m

@@ -105,7 +105,7 @@ vlc_module_begin ()
     set_callbacks( OpenIntf, CloseIntf )
     set_category( CAT_INTERFACE )
     set_subcategory( SUBCAT_INTERFACE_MAIN )
-    linked_with_a_crap_library_which_uses_atexit( )
+    cannot_unload_broken_library( )
     add_bool( "macosx-autoplay", true, NULL, AUTOPLAY_OSX_TEST, AUTOPLAY_OSX_LONGTEXT,
               false )
     add_bool( "macosx-recentitems", true, NULL, RECENT_ITEMS_TEXT, RECENT_ITEMS_LONGTEXT,

modules/gui/qt4/qt4.cpp

@@ -239,7 +239,7 @@ vlc_module_begin ()
     add_obsolete_integer( "qt-display-mode" ) /* Suppressed since 1.1.0 */
 
 #ifdef WIN32
-    linked_with_a_crap_library_which_uses_atexit()
+    cannot_unload_broken_library()
 #endif
 
     add_submodule ()

modules/misc/xml/libxml.c

@@ -47,7 +47,7 @@ vlc_module_begin ()
     set_callbacks( Open, Close )
 
 #ifdef WIN32
-    linked_with_a_crap_library_which_uses_atexit()
+    cannot_unload_broken_library()
 #endif
 
 vlc_module_end ()

modules/services_discovery/mtp.c

@@ -47,7 +47,7 @@ vlc_module_begin()
     set_subcategory( SUBCAT_PLAYLIST_SD )
     set_capability( "services_discovery", 0 )
     set_callbacks( Open, Close )
-    linked_with_a_crap_library_which_uses_atexit()
+    cannot_unload_broken_library()
 
     VLC_SD_PROBE_SUBMODULE
 vlc_module_end()

modules/video_output/msw/direct3d.c

@@ -74,7 +74,7 @@ vlc_module_begin ()
     set_callbacks(OpenVideoXP, Close)
 
     /* FIXME: Hack to avoid unregistering our window class */
-    linked_with_a_crap_library_which_uses_atexit()
+    cannot_unload_broken_library()
 
     add_submodule()
         set_capability("vout display", 150)

modules/video_output/msw/directx.c

@@ -116,7 +116,7 @@ vlc_module_begin()
     set_callbacks(Open, Close)
 
     /* FIXME: Hack to avoid unregistering our window class */
-    linked_with_a_crap_library_which_uses_atexit()
+    cannot_unload_broken_library()
 vlc_module_end()
 
 #if 0 /* FIXME */

modules/video_output/msw/glwin32.c

@@ -59,7 +59,7 @@ vlc_module_begin()
     set_callbacks(Open, Close)
 
     /* FIXME: Hack to avoid unregistering our window class */
-    linked_with_a_crap_library_which_uses_atexit ()
+    cannot_unload_broken_library ()
 vlc_module_end()
 
 #if 0 /* FIXME */

modules/video_output/sdl.c

@@ -69,7 +69,7 @@ vlc_module_begin()
     set_callbacks(Open, Close)
 #if defined(__i386__) || defined(__x86_64__)
     /* On i386, SDL is linked against svgalib */
-    linked_with_a_crap_library_which_uses_atexit()
+    cannot_unload_broken_library()
 #endif
 vlc_module_end()
 

modules/video_output/svgalib.c

@@ -61,7 +61,7 @@ vlc_module_begin ()
     set_description( N_("SVGAlib video output") )
     set_capability( "video output", 0 )
     set_callbacks( Create, Destroy )
-    linked_with_a_crap_library_which_uses_atexit ()
+    cannot_unload_broken_library () /* SVGAlib uses atexit() */
 vlc_module_end ()
 
 /*****************************************************************************