Commit 2c15f6cf authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont

PulseAudio: bug^Whint user about latency bug

parent 40330fdd
...@@ -36,6 +36,9 @@ ...@@ -36,6 +36,9 @@
#if !PA_CHECK_VERSION(0,9,22) #if !PA_CHECK_VERSION(0,9,22)
# include <vlc_xlib.h> # include <vlc_xlib.h>
#endif #endif
#if !PA_CHECK_VERSION(3,0,0)
# include <vlc_dialog.h>
#endif
static int Open ( vlc_object_t * ); static int Open ( vlc_object_t * );
static void Close ( vlc_object_t * ); static void Close ( vlc_object_t * );
...@@ -315,7 +318,25 @@ static void stream_latency_cb(pa_stream *s, void *userdata) ...@@ -315,7 +318,25 @@ static void stream_latency_cb(pa_stream *s, void *userdata)
bool sync = false; bool sync = false;
if (delta < -AOUT_MAX_PTS_DELAY) if (delta < -AOUT_MAX_PTS_DELAY)
{
msg_Warn(aout, "too late by %"PRId64" us", -delta); msg_Warn(aout, "too late by %"PRId64" us", -delta);
#if !PA_CHECK_VERSION(3,0,0)
if (delta < -CLOCK_FREQ)
{
var_Create (aout->p_libvlc, "pulse-broken", VLC_VAR_BOOL);
if (!var_GetBool (aout->p_libvlc, "pulse-broken"))
{
var_SetBool (aout->p_libvlc, "pulse-broken", true);
dialog_Fatal (aout, "Potential PulseAudio version problem",
"PulseAudio is streaming with an excessive latency. "
"Sound may be lost or quality degraded.\n"
"To address that issue, upgrade the PulseAudio daemon "
"to version 3.0, or disable the alternate sampling rate "
"in its configuration.");
}
}
#endif
}
else if (delta > +AOUT_MAX_PTS_ADVANCE) else if (delta > +AOUT_MAX_PTS_ADVANCE)
msg_Warn(aout, "too early by %"PRId64" us", delta); msg_Warn(aout, "too early by %"PRId64" us", delta);
else if (outrate == inrate) else if (outrate == inrate)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment