Commit 2b50f07b authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont

Remove invalid VOUT_REPARENT uses

as discussed^Wmonologued on the mailing list.
parent dd70e014
...@@ -249,15 +249,7 @@ static void Run( intf_thread_t *p_intf ) ...@@ -249,15 +249,7 @@ static void Run( intf_thread_t *p_intf )
var_DelCallback( p_intf->p_sys->p_playlist, "activity", var_DelCallback( p_intf->p_sys->p_playlist, "activity",
activity_cb, p_intf ); activity_cb, p_intf );
// Asking the vout to close assert( !p_intf->p_sys->p_vout ); /* too late */
vout_thread_t *p_vout = p_intf->p_sys->p_vout;
if( p_vout )
{
vout_Control( p_vout, VOUT_REPARENT, 0 );
vlc_object_release( p_vout );
}
gtk_object_destroy( GTK_OBJECT( window ) ); gtk_object_destroy( GTK_OBJECT( window ) );
} }
......
...@@ -196,15 +196,12 @@ VlcProc::~VlcProc() ...@@ -196,15 +196,12 @@ VlcProc::~VlcProc()
var_DelCallback( getIntf(), "skin-to-load", onSkinToLoad, this ); var_DelCallback( getIntf(), "skin-to-load", onSkinToLoad, this );
} }
#include <assert.h>
void VlcProc::registerVoutWindow( void *pVoutWindow ) void VlcProc::registerVoutWindow( void *pVoutWindow )
{ {
m_handleSet.insert( pVoutWindow ); m_handleSet.insert( pVoutWindow );
// Reparent the vout window assert( !m_pVout );
if( m_pVout )
{
vout_Control( m_pVout, VOUT_REPARENT, 0 );
}
} }
...@@ -216,11 +213,7 @@ void VlcProc::unregisterVoutWindow( void *pVoutWindow ) ...@@ -216,11 +213,7 @@ void VlcProc::unregisterVoutWindow( void *pVoutWindow )
void VlcProc::dropVout() void VlcProc::dropVout()
{ {
if( m_pVout ) assert( !m_pVout );
{
vout_Control( m_pVout, VOUT_REPARENT, 0 );
m_pVout = NULL;
}
} }
......
...@@ -764,7 +764,6 @@ void libvlc_media_player_set_drawable( libvlc_media_player_t *p_mi, ...@@ -764,7 +764,6 @@ void libvlc_media_player_set_drawable( libvlc_media_player_t *p_mi,
libvlc_exception_t *p_e ) libvlc_exception_t *p_e )
{ {
input_thread_t *p_input_thread; input_thread_t *p_input_thread;
vout_thread_t *p_vout = NULL;
p_mi->drawable.xid = drawable; p_mi->drawable.xid = drawable;
...@@ -779,12 +778,6 @@ void libvlc_media_player_set_drawable( libvlc_media_player_t *p_mi, ...@@ -779,12 +778,6 @@ void libvlc_media_player_set_drawable( libvlc_media_player_t *p_mi,
return; return;
} }
p_vout = vlc_object_find( p_input_thread, VLC_OBJECT_VOUT, FIND_CHILD );
if( p_vout )
{
vout_Control( p_vout , VOUT_REPARENT, drawable);
vlc_object_release( p_vout );
}
vlc_object_release( p_input_thread ); vlc_object_release( p_input_thread );
} }
......
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
* *
* $Id$ * $Id$
* *
* Authors: Clent Stenac <zorglub@videolan.org> * Authors: Clément Stenac <zorglub@videolan.org>
* Filippo Carone <littlejohn@videolan.org> * Filippo Carone <littlejohn@videolan.org>
* Jean-Paul Saman <jpsaman _at_ m2x _dot_ nl> * Jean-Paul Saman <jpsaman _at_ m2x _dot_ nl>
* Damien Fouilleul <damienf a_t videolan dot org> * Damien Fouilleul <damienf a_t videolan dot org>
...@@ -190,14 +190,9 @@ int libvlc_media_player_has_vout( libvlc_media_player_t *p_mi, ...@@ -190,14 +190,9 @@ int libvlc_media_player_has_vout( libvlc_media_player_t *p_mi,
int libvlc_video_reparent( libvlc_media_player_t *p_mi, libvlc_drawable_t d, int libvlc_video_reparent( libvlc_media_player_t *p_mi, libvlc_drawable_t d,
libvlc_exception_t *p_e ) libvlc_exception_t *p_e )
{ {
vout_thread_t *p_vout = GetVout( p_mi, p_e ); (void) p_mi; (void) d;
libvlc_exception_raise(p_e, "Reparenting not supported");
if( p_vout ) return -1;
{
vout_Control( p_vout , VOUT_REPARENT, d);
vlc_object_release( p_vout );
}
return 0;
} }
void libvlc_video_resize( libvlc_media_player_t *p_mi, int width, int height, libvlc_exception_t *p_e ) void libvlc_video_resize( libvlc_media_player_t *p_mi, int width, int height, libvlc_exception_t *p_e )
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment