Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc-gpu
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc-gpu
Commits
0790860f
Commit
0790860f
authored
Aug 05, 2007
by
Rémi Denis-Courmont
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix NULL dereference due to Speex header corruption
spotted by David Thiel
parent
a7d566c6
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
0 deletions
+7
-0
modules/codec/speex.c
modules/codec/speex.c
+7
-0
No files found.
modules/codec/speex.c
View file @
0790860f
...
@@ -35,6 +35,8 @@
...
@@ -35,6 +35,8 @@
#include <speex/speex_stereo.h>
#include <speex/speex_stereo.h>
#include <speex/speex_callbacks.h>
#include <speex/speex_callbacks.h>
#include <assert.h>
/*****************************************************************************
/*****************************************************************************
* decoder_sys_t : speex decoder descriptor
* decoder_sys_t : speex decoder descriptor
*****************************************************************************/
*****************************************************************************/
...
@@ -341,6 +343,8 @@ static int ProcessInitialHeader( decoder_t *p_dec, ogg_packet *p_oggpacket )
...
@@ -341,6 +343,8 @@ static int ProcessInitialHeader( decoder_t *p_dec, ogg_packet *p_oggpacket )
}
}
p_mode
=
speex_mode_list
[
p_header
->
mode
];
p_mode
=
speex_mode_list
[
p_header
->
mode
];
if
(
p_mode
==
NULL
)
return
VLC_EGENERIC
;
if
(
p_header
->
speex_version_id
>
1
)
if
(
p_header
->
speex_version_id
>
1
)
{
{
...
@@ -555,7 +559,10 @@ static void ParseSpeexComments( decoder_t *p_dec, ogg_packet *p_oggpacket )
...
@@ -555,7 +559,10 @@ static void ParseSpeexComments( decoder_t *p_dec, ogg_packet *p_oggpacket )
if
(
p_input
->
i_object_type
!=
VLC_OBJECT_INPUT
)
return
;
if
(
p_input
->
i_object_type
!=
VLC_OBJECT_INPUT
)
return
;
assert
(
p_sys
->
p_header
->
mode
<
SPEEX_NB_MODES
);
p_mode
=
speex_mode_list
[
p_sys
->
p_header
->
mode
];
p_mode
=
speex_mode_list
[
p_sys
->
p_header
->
mode
];
assert
(
p_mode
!=
NULL
);
input_Control
(
p_input
,
INPUT_ADD_INFO
,
_
(
"Speex comment"
),
_
(
"Mode"
),
input_Control
(
p_input
,
INPUT_ADD_INFO
,
_
(
"Speex comment"
),
_
(
"Mode"
),
"%s%s"
,
p_mode
->
modeName
,
"%s%s"
,
p_mode
->
modeName
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment