At startup of the decoder, i_channels might be set to 0 if the decoder
hasn't processed the sent CODECCONFIG data yet. (In these cases, the
returned buffers are 0 bytes long so we don't miss anything either.)
A port reconfigure event is sent in these cases, so i_channels gets
initialized to the right value before we handle any later buffers with
actual content.
Signed-off-by: Martin Storsjö <martin@martin.st>

It's mostly enough to call it on the input port, while we later get
back what the decoder itself set on the output port (based on the
input port and codec config data), so if this fails, just ignore it.

This is required for using google SW audio codecs via OMX, which is
useful mostly for testing. (Using them still requires a few more
hacks though.)
Signed-off-by: Martin Storsjö <martin@martin.st>

This does work with the Samsung AAC decoder (which seems to support
both), while the google SW AAC decoder doesn't support the previous
value (but works fine with this one).

As far as I can read the specs, the two formats are identical (one
is defined as "AAC inside MPEG-4/ISO File Format" while the other
one is defined as "AAC Raw Format (access units)").

The Android media stack seems to be using this one internally
(with a bunch of references to this one, and no references to the
RAW one), which is a good indication that at least most android
AAC decoders should be able to handle it.
Signed-off-by: Martin Storsjö <martin@martin.st>

This doesn't seem to have any effect in practice, but it does make
the code more correct.
Signed-off-by: Martin Storsjö <martin@martin.st>

Signed-off-by: Martin Storsjö <martin@martin.st>

The dummy support patch also fix #5287.

We don't display both sliders at once anyway.

Never more than one piece of text is displayed at a time anyway.
Also simplify format string handling and use single precision maths.

(Functions reordered to avoid forward declaration.)

This fixes the problem that SAP hangs on even if it has been canceled.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

This is tested to be working on Galaxy S3 on 4.1.2 (and
on 4.1.1 as well).

(WMV3 doesn't seem to work though, even after reformatting the
extradata as in the omxil decoder, MediaCodec.configure()
throws an exception.)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Previously, we checked that the event queue had an OMX_EventCmdComplete
item, but we didn't make sure that it was for the previously issued
OMX_CommandStateSet. In many cases, it was from a OMX_CommandFlush,
which made the code proceed with other deinitialization. If the decoder
hadn't actually transitioned to idle state yet, the buffers weren't
actually ever freed (in the state == OMX_StateIdle block), which lead
to crashes when the handle was freed at the end.

This fixes crashes when finishing playback of wmv3 videos on Galaxy S3.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

This one doesn't seem to work for either VC1 or WMV3 at the moment
(on Android 4.1.2 on Galaxy S3), while OMX.SEC.vc1.dec works (for
both codecs).
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Some OMX decoders that can handle WMV3 (such as the broadcom one
in raspberry pi) can handle the WMV3 extradata both in the original
form as in ASF, and in this format, while the one in Samsung Galaxy
S3 requires it to be in this format (as the OMX IL 1.2 specs specify).

This makes HW-accelerated WMV3 decoding work on Galaxy S3.

The code can be split out to a reusable function if/when the same
needs to be done elsewhere.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>