These were broken since 6270a4c7.

This reverts commit 6b2d303b.
This fixes #8220.

Also remove dated comment.

Luckily, signed and unsigned int are compatible types.

close #7971

Close #8199

This requires passing the original VLC codec id to the function,
since both variants are mapped to OMX_AUDIO_CodingAMR.

We don't set the actual correct band mode (since we don't know
what bitrate mode is used for each frame, since it can vary), but
we set mode 0. We could in principle set it more accurately based
on bitrate, but since it can vary from frame to frame, this should
be enough anyway.

This is required for OMX.SEC.amr.dec, which is one single codec
supporting both AMR variant roles, and this seems to be the way of
signalling what AMR variant it is. If setting
OMX_AUDIO_AMRBandModeUnused, the codec fails to initialize.

A codec can get this info either by having two separate OMX codecs,
such as OMX.google.amrnb.decoder vs OMX.google.amrwb.decoder, by
checking what the caller set via OMX_IndexParamStandardComponentRole
or via the band mode parameter - the samsung decoder seems to use
the band mode.
Signed-off-by: Martin Storsjö <martin@martin.st>

The previously used enum is only used for conformance tests and
is not the one commonly used in practice - the file storage format
is the commonly used one (which also is used within Android).
Signed-off-by: Martin Storsjö <martin@martin.st>

These are the role names mentioned in the OMX IL spec, used by
Android's built-in SW codecs and by the HW codecs available on
Samsung Galaxy S3.
Signed-off-by: Martin Storsjö <martin@martin.st>

This fixes stray log warnings when using audio decoders, since
4edfa4f5.
Signed-off-by: Martin Storsjö <martin@martin.st>

auhal: export System Sound Output Device as another choice if the user wants VLC to suit the default OS behavior

Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

auhal: use kAudioObjectPropertyName instead of kAudioDevicePropertyDeviceName to retrieve the (potentially localized) device name

This is the endorsed API and behaves correctly with regard to string lengths

This reverts commit a446ef28.

This rounds up to exactly 441 samples with 44.1kHz audio
This avoids a rounding error in drift calculation of 2.31 milliseconds
in the worst case of the buffers queue being full for the specific
case of 44.1kHz audio (such a small error is not significative).

For unknown reasons it also fixes A/V sync issues.

Also fixes a memory leak

macosx: only revert presentation options on fullscreen leave which are touched when entering fs for this particular window

This fixes menu / dock hide behaviour when handling around with multiple
vout windows which are set to fullscreen on multiple monitors, especially when
leaving fullscreen for one window with other windows still in fullscreen state.