AC_CHECK_HEADERS does not work the way this change assumes. This commit
did not fix the stated problem.

This reverts commit 4e33295f.

Also scale maximum down to 2 times the nominal volume (i.e. +18dB) to
stay in the recommended range of +10 to +20dB.

The formula should be changed in any case. WaveOut has a logarithmic
scale, which is not consistent with the other audio outputs.

aout_VolumeUp() already handles this case correctly internally.

1.0 is nominal, not maximum. This is consistent with both VLC and the
MPRIS 2.1 specification. Also, the setter ought to have the same scale
as the getter!

(Do not assume that AOUT_VOLUME_MAX is 4 times AOUT_VOLUME_DEFAULT.)

VLC (like PulseAudio) stores the software volume i.e. the position of
the volume UI slider, rather than the linear amplification multiplier.

So do not use PulseAudio linear to volume conversion. Otherwise the
VLC volume gets wrongly cube-rooted.

We do not need to care which functions are in the math library. We only
need to care whether libm actually exists and can be linked against.

And by the way, lets define @LIBM@ for makefiles.

macosx: implemented both skipping within an item and item changing for the forward/backward buttons (closes #4943)

removed remnants of the Dudiak interface, added PXSourceList by Alex Rozanski (BSD-new licensed) which will be used for the new implementation, added a to-be-replaced png for the window's topbar

Didn't notice them first time.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

This should cleanup locking when applying the volume, though there are
still some (non-crashing) races in setting/getting the volume.

This also adds an API to report the volume from the output, though it's
currently left as a dummy.

This assumption is correct and already present in plenty of code paths
(e.g. when converting to/from float).

untested, since the affected code is part of the S/PDIF handling

Otherwise the next probed plugin would get a potentially corrupted
input format. This bug may affect other audio output plugins and
similarly even some video outptu display plugins (not checked yet).

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

New doxygen command \libvlc_return_bool means that wrapper generators
should translate returning int to a boolean value.

For example, this is useful for Ruby, where every number, including 0,
is considered to be true.

For normal HTML/LaTeX documentation it's invisible.
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>