This reverts commit 0970461e.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

This should suffice as the variable is only modified on this thread.
Avoids deadlock in refs #9141

In direct rendering mode a picture reference is acquired from the video output
module. This reference has to be released when the internal omx buffer which
uses this reference is freed. This avoids a blocking condition where the video
output would wait for a picture to be freed forever.
Signed-off-by: Julian Scheel <julian@jusst.de>
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Activate the mpeg2 module in the broadcom omx core. If this is used on a
Raspberry it is required to have a MPEG2 license key to activate this core.
Signed-off-by: Julian Scheel <julian@jusst.de>
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Same issue as mp3 .raw extensions

fLaC marker is helpful for file format detection

Close #9223

Close #9222

That doesn't really make sense

Make code more verbose and easy to read

This reverts commit 03ae4817.

Fix regression introduced in 95f14593

ConfigControl::getName() uses memory of p_item which is a part of p_config memory. This was causing a crash when trying to save the preferences, as the constructor had already destroyed it upon creation.

Instead, free the p_config memory on the destructor, which is automatically called when the dialog closes, saved or cancelled. Verified to not leak any memory.

Close #9214
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Close #9200

Without this fix, they are indistinguishable in the GUI and the user cannot know which is which.
Pointed-out-by: Eric Hameleers <alien@slackware.com>
Signed-off-by: Rafaël Carré <funman@videolan.org>

Normalise it with other options in advanced prefs.
Signed-off-by: Rafaël Carré <funman@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>