Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

The original code was non-working because the notication was never
setup correctly and resulted in a DSERR_INVALIDCALL. A proper fix
would look like:

         if( sys->p_notify )
         {
+            IDirectSoundBuffer_Stop( aout->sys->p_dsbuffer );
             DSBPOSITIONNOTIFY notif = {.dwOffset = aout->sys->i_write, .hEventNotify = sys->hnotify_evt } ;
             if( IDirectSoundNotify_SetNotificationPositions( sys->p_notify, 1, &notif ) ==  DS_OK )
             {
+                IDirectSoundBuffer_Play( aout->sys->p_dsbuffer, 0, 0, DSBPLAY_LOOPING );
                 WaitForSingleObject( sys->hnotify_evt, INFINITE );
                 IDirectSoundBuffer_Stop( aout->sys->p_dsbuffer );
             }

But fixing it makes the problem worse since the notification is setup
too late and thus the buffer will replay a full loop of the back
buffer during a drain.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

With the reference counting stuff, the AVFrame structure is gone or
unreachable by the time the release function is called.

This will simplify later commits.

This can happen in some corner cases such as flushing (luckily the leak
would automatically be resolved when the device instance is released).

This reenables direct rendering with libavcodec in most cases.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Functions are provided to:

 * query the available equalizer presets
 * create a new default equalizer instance
 * create an equalizer instance from a preset
 * set individual equalizer band amplitudes
 * set equalizer pre-amplification
 * apply an equalizer to a media player

Equalizer settings can be applied whether media is playing or not,
and will automatically be retained when playing media subsequently.
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Fixes: #8516

In C, an enumeration is unsigned unless it contains an explicit negative
member.

no new strings.

close #8628

refs #8628

This patch doesn't stop you from going above the limit using the hotkeys or the Apple Remote

Modified-by: Rafaël Carré <funman@videolan.org>
Signed-off-by: Rafaël Carré <funman@videolan.org>

Fixes: #3899