This reverts commit 93900cd7 because it breaks the API behavior 3 months after a feature freeze without providing a proper solution or work-around. This code path will be reworked for 3.0.

(cherry picked from commit 08c15c3f4c2b16dfe8189458a8bac17221e43f97)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit 1ec8c36705246b191053b6ebec1491c121cf521a)
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

Switch the layout activity to true before actually displaying the layout. This
gives controls a chance to reinitialize before any real drawing occurs, and
thus a clean animation gets displayed without any unwanted stray image.

This fixes trac #12083

(cherry picked from commit 1ce3c5d673ba7a71f3db5cf7f1d11ee906f92d39)
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

If down or over images are missing, they default to the up image. Yet, in case
of animated images, the animation gets played leading to undesirable artefacts.

This patch adds a comparison operator for animated images and do not restart the
animation if they are alike.

(cherry picked from commit 1c101b97678e5e7a34a062916b24fe0b9366a316)
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

(cherry picked from commit d32f040df7c85f9331cf5f5aa6438a84e2ad8360)

(cherry picked from commit c8803e34fe597809dd5b558e0cdcc811c0cc41fd)

(cherry picked from commit c5f806f480c9eda637b741d29c11b1b00e2a6f06)

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
(cherry picked from commit 26e73f0ff54f6f65519443679748c75d437f03ba)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Tristan Matthews <le.businessman@gmail.com>
(cherry picked from commit 52897c9020a3b8044d77866605068509924a585c)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit 0ff2de0533d1197d2dc2f17ad9093cc7b9541402)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Fix AAC-LC playback with QT 10.3 (727.4)

(cherry picked from commit 08f8853b60ad68629b14aabea1595047ef7a3288)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit 407756f250d57b50b6bd20be74c7247c94ce3a3f)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

A crash could occur in the following situation:
1) A video decoder is created and starts waiting for the first picture:
   b_waiting = true, b_first = true

2) The first picture is received but the decoder is still in waiting mode:
   b_waiting = true, b_first = false

3) A second picture is received, the decoder is now waiting in
DecoderWaitUnblock().

4) From the input thread, an EOF event is received, EsOutChangePosition is
called and sets the decoder in flushing mode.

5) The decoder thread wakes up and exits DecoderWaitUnblock because
b_flushing is true. However this triggers the assertion in
DecoderDecodeVideo since we have b_waiting && !b_first.

Fix #11892, #12041

(cherry picked from commit a1603d9e69629a8168f5babce3388307bb677341)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit a14188589fbbbfc404be45a80db90d6e1725de4e)

In combination with the previous patch all crashes (double free()) are solved.
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
(cherry picked from commit 1651d75c07ae1795cf78b0e3e4ac753b7703a8e6)

(cherry picked from commit 2051d837ea9066c4ddf388b7940652bb0c8d549c)

macosx: contacting an app using SBApplication can fail, be a bit more conservative to prevent runtime exceptions

(cherry picked from commit e9981efbf126136807a87215d0ce8aade192b846)

(cherry picked from commit 496c2575e067edc195227380c41ed69016df36bb)

Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>
(cherry picked from commit f1ccba2fc364dfb8201461307a1cf6a5c1b2e7fd)
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

(cherry picked from commit 677511e79bdc42bddec1b57977973b2489772099)
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

Avoids setting this variable multiple times, as each time vout
restart is requested. Also avoids unnecessary vout restarts at
start and when changing profiles.

refs #12063

(cherry picked from commit ddccf6b050412f348a00c12b857a48d4ac5e2b63)
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

(cherry picked from commit d23ddc933c7505d54fd9fd19040803d5b8c8f888)
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

- add signing of sparkles autoupdate tool
- directly fail on error
- fix bug preventing signing of VLC binary
- rework validation steps so that it validates frameworks and autoupdate
  tool separately, but then the complete bundle like gatekeeper (using
  --deep option)
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>
(cherry picked from commit 699533d5b940bad7ddaffff99f31c83da630fd55)

This interferes with overlay-based outputs, and serves no useful
purpose for VLC since the video frames are always fully opaque.

(cherry picked from commit 345fa6c345d839ff3bec9c0f455e0eb2034f0369)

(cherry picked from commit 2d681f4c38745132a18fc7ba8163df5aab96346b)

mac frameworks use symlinks for their internal structure. This
reduces size of delivered framework folders by a factor of 3.

Also correctly clean the BGHUDAppkit ressources folder. Info.plist
must remain for proper code signing.

(cherry picked from commit 468c9ea3a6231ee63a0de40bda63e28f9b431a46)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit 38ed035eaa96ef8d0ab7bffc274566814f677d2b)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Close #11740

(cherry picked from commit 84bdd0e765a83978fd246277d4b290ced72086b7)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit d53688897ec773695def279cea2a179d5620c4e9)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit aed1b6da46d484f18dbb36dbb5e62c4d4f9ec070)

(cherry picked from commit 832510eb27f32d6e08451d7591a8149caadff935)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
(cherry picked from commit 9ac30b31fc91e5a47135c1ca2f9c08ea0f5c255d)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
(cherry picked from commit 38dab127daa980ca706b5315be17736f8f795e42)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
(cherry picked from commit b1f9242606caf549a03c6b11b00c66c2c1af27cb)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
(cherry picked from commit 5064767f8e2de7299bbb00652fd04ac5a70de4ce)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
(cherry picked from commit ecd7f4e2e784e908626afe9804bc380abb07115e)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit dc2a22c095453c40657f5ac83a289740beceb30e)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>