Skip to content

V
vlc-2-2
Commit fe5063ec authored by Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf
Browse files
Options

Fix possible XSS in httpd_HtmlError 

Found by Francesco Perna and Pietro Minniti from Quantum Leap s.r.l
Quantum Leap Advisory: Adivsory #QLA140216
parent 8cc28d2b
Hide whitespace changes
Inline Side-by-side
Showing with 5 additions and 1 deletion
src/network/httpd.c
View file @ fe5063ec
...@@ -265,6 +265,8 @@ static size_t httpd_HtmlError (char **body, int code, const char *url) ...@@ -265,6 +265,8 @@ static size_t httpd_HtmlError (char **body, int code, const char *url)
const char *errname = httpd_ReasonFromCode (code); const char *errname = httpd_ReasonFromCode (code);
assert (errname != NULL); assert (errname != NULL);
char *url_Encoded = convert_xml_special_chars (url ? url : "");
int res = asprintf (body, int res = asprintf (body,
"<?xml version=\"1.0\" encoding=\"ascii\" ?>\n" "<?xml version=\"1.0\" encoding=\"ascii\" ?>\n"
"<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Strict//EN\"" "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Strict//EN\""
...@@ -279,7 +281,9 @@ static size_t httpd_HtmlError (char **body, int code, const char *url) ...@@ -279,7 +281,9 @@ static size_t httpd_HtmlError (char **body, int code, const char *url)
"<a href=\"http://www.videolan.org\">VideoLAN</a>\n" "<a href=\"http://www.videolan.org\">VideoLAN</a>\n"
"</body>\n" "</body>\n"
"</html>\n", errname, code, errname, "</html>\n", errname, code, errname,
(url ? " (" : ""), (url ? url : ""), (url ? ")" : "")); (url_Encoded ? " (" : ""), (url_Encoded ? url_Encoded : ""), (url_Encoded ? ")" : ""));
free (url_Encoded);
if (res == -1) if (res == -1)
{ {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment