Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc-2-2
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc-2-2
Commits
bdbd8588
Commit
bdbd8588
authored
Jan 24, 2010
by
Jean-Philippe André
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Extensions: fix compilation for Windoze
Windows already registers CreateDialog as a macro
parent
8f055856
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
13 additions
and
11 deletions
+13
-11
modules/gui/qt4/dialogs/extensions.cpp
modules/gui/qt4/dialogs/extensions.cpp
+10
-8
modules/gui/qt4/dialogs/extensions.hpp
modules/gui/qt4/dialogs/extensions.hpp
+3
-3
No files found.
modules/gui/qt4/dialogs/extensions.cpp
View file @
bdbd8588
...
...
@@ -55,7 +55,7 @@ ExtensionsDialogProvider::ExtensionsDialogProvider( intf_thread_t *_p_intf,
var_AddCallback
(
p_intf
,
"dialog-extension"
,
DialogCallback
,
NULL
);
CONNECT
(
this
,
SignalDialog
(
extension_dialog_t
*
),
this
,
UpdateDialog
(
extension_dialog_t
*
)
);
this
,
Update
Ext
Dialog
(
extension_dialog_t
*
)
);
}
ExtensionsDialogProvider
::~
ExtensionsDialogProvider
()
...
...
@@ -65,20 +65,21 @@ ExtensionsDialogProvider::~ExtensionsDialogProvider()
/** Create a dialog
* Note: Lock on p_dialog->lock must be held. */
ExtensionDialog
*
ExtensionsDialogProvider
::
CreateDialog
(
extension_dialog_t
*
p_dialog
)
ExtensionDialog
*
ExtensionsDialogProvider
::
CreateExtDialog
(
extension_dialog_t
*
p_dialog
)
{
ExtensionDialog
*
dialog
=
new
ExtensionDialog
(
p_intf
,
p_extensions_manager
,
p_dialog
);
p_dialog
->
p_sys_intf
=
(
void
*
)
dialog
;
CONNECT
(
dialog
,
destroyDialog
(
extension_dialog_t
*
),
this
,
DestroyDialog
(
extension_dialog_t
*
)
);
this
,
Destroy
Ext
Dialog
(
extension_dialog_t
*
)
);
return
dialog
;
}
/** Destroy a dialog
* Note: Lock on p_dialog->lock must be held. */
int
ExtensionsDialogProvider
::
DestroyDialog
(
extension_dialog_t
*
p_dialog
)
int
ExtensionsDialogProvider
::
Destroy
Ext
Dialog
(
extension_dialog_t
*
p_dialog
)
{
assert
(
p_dialog
);
ExtensionDialog
*
dialog
=
(
ExtensionDialog
*
)
p_dialog
->
p_sys_intf
;
...
...
@@ -92,7 +93,8 @@ int ExtensionsDialogProvider::DestroyDialog( extension_dialog_t *p_dialog )
/**
* Update/Create/Destroy a dialog
**/
ExtensionDialog
*
ExtensionsDialogProvider
::
UpdateDialog
(
extension_dialog_t
*
p_dialog
)
ExtensionDialog
*
ExtensionsDialogProvider
::
UpdateExtDialog
(
extension_dialog_t
*
p_dialog
)
{
assert
(
p_dialog
);
...
...
@@ -107,7 +109,7 @@ ExtensionDialog* ExtensionsDialogProvider::UpdateDialog( extension_dialog_t *p_d
vlc_mutex_lock
(
&
p_dialog
->
lock
);
if
(
!
p_dialog
->
b_kill
&&
!
dialog
)
{
dialog
=
CreateDialog
(
p_dialog
);
dialog
=
Create
Ext
Dialog
(
p_dialog
);
dialog
->
setVisible
(
!
p_dialog
->
b_hide
);
}
else
if
(
!
p_dialog
->
b_kill
&&
dialog
)
...
...
@@ -119,7 +121,7 @@ ExtensionDialog* ExtensionsDialogProvider::UpdateDialog( extension_dialog_t *p_d
}
else
if
(
p_dialog
->
b_kill
)
{
DestroyDialog
(
p_dialog
);
Destroy
Ext
Dialog
(
p_dialog
);
}
vlc_cond_signal
(
&
p_dialog
->
cond
);
vlc_mutex_unlock
(
&
p_dialog
->
lock
);
...
...
@@ -137,7 +139,7 @@ void ExtensionsDialogProvider::ManageDialog( extension_dialog_t *p_dialog )
if
(
!
extMgr
->
isUnloading
()
)
emit
SignalDialog
(
p_dialog
);
// Safe because we signal Qt thread
else
UpdateDialog
(
p_dialog
);
// This is safe, we're already in Qt thread
Update
Ext
Dialog
(
p_dialog
);
// This is safe, we're already in Qt thread
}
/**
...
...
modules/gui/qt4/dialogs/extensions.hpp
View file @
bdbd8588
...
...
@@ -54,9 +54,9 @@ private:
extensions_manager_t
*
p_extensions_manager
;
private
slots
:
ExtensionDialog
*
CreateDialog
(
extension_dialog_t
*
p_dialog
);
int
DestroyDialog
(
extension_dialog_t
*
p_dialog
);
ExtensionDialog
*
UpdateDialog
(
extension_dialog_t
*
p_dialog
);
ExtensionDialog
*
Create
Ext
Dialog
(
extension_dialog_t
*
p_dialog
);
int
Destroy
Ext
Dialog
(
extension_dialog_t
*
p_dialog
);
ExtensionDialog
*
Update
Ext
Dialog
(
extension_dialog_t
*
p_dialog
);
public:
ExtensionsDialogProvider
(
intf_thread_t
*
p_intf
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment