Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc-2-2
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc-2-2
Commits
b70cb5b9
Commit
b70cb5b9
authored
May 19, 2014
by
Jean-Baptiste Kempf
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Qt: s/Qt4/Qt
parent
9720a180
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
10 additions
and
10 deletions
+10
-10
modules/gui/qt4/HACKING
modules/gui/qt4/HACKING
+3
-3
modules/gui/qt4/components/playlist/playlist_model.hpp
modules/gui/qt4/components/playlist/playlist_model.hpp
+1
-1
modules/gui/qt4/main_interface.cpp
modules/gui/qt4/main_interface.cpp
+3
-3
modules/gui/qt4/qt4.cpp
modules/gui/qt4/qt4.cpp
+3
-3
modules/gui/qt4/recents.cpp
modules/gui/qt4/recents.cpp
+0
-0
No files found.
modules/gui/qt4/HACKING
View file @
b70cb5b9
Small Hacking file for the Qt Interface
If you ever code for Qt
4
interface, please read this before.
If you ever code for Qt interface, please read this before.
** Code Convetions **
...
...
@@ -18,7 +18,7 @@ Refer to http://wiki.videolan.org/Code_Conventions it should be up to date
- VLC include/*.h includes
- Other VLC .h includes (gruiking :D)
- Qt
4
module includes
- Qt module includes
- Qt includes
** Naming **
...
...
@@ -43,7 +43,7 @@ So if your dialog is a dialog you are used to keep during a playing of a video,
QVLCFrame: extended panel, messages...
QVLCDialog: preferences, open...
** HIG for Qt
4
**
** HIG for Qt **
We tend to use GNOME/KDE specs over Vista ones for capitalizations:
We use Header for:
- Menu
...
...
modules/gui/qt4/components/playlist/playlist_model.hpp
View file @
b70cb5b9
...
...
@@ -56,7 +56,7 @@ public:
playlist_item_t
*
,
QObject
*
parent
=
0
);
virtual
~
PLModel
();
/* Qt
4
main PLModel */
/* Qt main PLModel */
static
PLModel
*
getPLModel
(
intf_thread_t
*
p_intf
)
{
if
(
!
p_intf
->
p_sys
->
pl_model
)
...
...
modules/gui/qt4/main_interface.cpp
View file @
b70cb5b9
...
...
@@ -640,8 +640,8 @@ void MainInterface::toggleFSC()
/**
* NOTE:
* You must not change the state of this object or other Qt
4
UI objects,
* from the video output thread - only from the Qt
4
UI main loop thread.
* You must not change the state of this object or other Qt UI objects,
* from the video output thread - only from the Qt UI main loop thread.
* All window provider queries must be handled through signals or events.
* That's why we have all those emit statements...
*/
...
...
@@ -691,7 +691,7 @@ void MainInterface::releaseVideoSlot( void )
{
/* This function is called when the embedded video window is destroyed,
* or in the rare case that the embedded window is still here but the
* Qt
4
interface exits. */
* Qt interface exits. */
assert
(
videoWidget
);
videoWidget
->
release
();
setVideoOnTop
(
false
);
...
...
modules/gui/qt4/qt4.cpp
View file @
b70cb5b9
...
...
@@ -704,9 +704,9 @@ static void WindowClose( vout_window_t *p_wnd )
QMutexLocker
locker
(
&
lock
);
/* Normally, the interface terminates after the video. In the contrary, the
* Qt
4
main loop is gone, so we cannot send any event to the user interface
* widgets. Ideally, we would keep the Qt
4
main loop running until after
* the video window is released. But it is far simpler to just have the Qt
4
* Qt main loop is gone, so we cannot send any event to the user interface
* widgets. Ideally, we would keep the Qt main loop running until after
* the video window is released. But it is far simpler to just have the Qt
* thread destroy the window early, and to turn this function into a stub.
*
* That assumes the video output will behave sanely if it window is
...
...
modules/gui/qt4/recents.cpp
100755 → 100644
View file @
b70cb5b9
File mode changed from 100755 to 100644
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment