Skip to content

V
vlc-2-2
Commit a1358b0c authored by Rémi Duraffort's avatar Rémi Duraffort
Browse files
Options

visual: avoid a strdup/free.

parent 0412df76
Hide whitespace changes
Inline Side-by-side
Showing with 1 addition and 7 deletions
modules/visualization/visual/visual.c
View file @ a1358b0c
...@@ -189,12 +189,10 @@ static int Open( vlc_object_t *p_this ) ...@@ -189,12 +189,10 @@ static int Open( vlc_object_t *p_this )
{ {
aout_filter_t *p_filter = (aout_filter_t *)p_this; aout_filter_t *p_filter = (aout_filter_t *)p_this;
aout_filter_sys_t *p_sys; aout_filter_sys_t *p_sys;
vlc_value_t val;
char *psz_effects, *psz_parser; char *psz_effects, *psz_parser;
video_format_t fmt; video_format_t fmt;
if( ( p_filter->input.i_format != VLC_FOURCC('f','l','3','2') && if( ( p_filter->input.i_format != VLC_FOURCC('f','l','3','2') &&
p_filter->input.i_format != VLC_FOURCC('f','i','3','2') ) ) p_filter->input.i_format != VLC_FOURCC('f','i','3','2') ) )
{ {
...@@ -217,11 +215,7 @@ static int Open( vlc_object_t *p_this ) ...@@ -217,11 +215,7 @@ static int Open( vlc_object_t *p_this )
p_sys->effect = NULL; p_sys->effect = NULL;
/* Parse the effect list */ /* Parse the effect list */
var_Create( p_filter, "effect-list", VLC_VAR_STRING | VLC_VAR_DOINHERIT ); psz_parser = psz_effects = var_CreateGetString( p_filter, "effect-list" );
var_Get( p_filter, "effect-list", &val);
psz_parser = psz_effects = strdup( val.psz_string );
free( val.psz_string );
var_AddCallback( p_filter, "effect-list", FilterCallback, NULL ); var_AddCallback( p_filter, "effect-list", FilterCallback, NULL );
while( psz_parser && *psz_parser != '\0' ) while( psz_parser && *psz_parser != '\0' )
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment