Commit 549e3f43 authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont

modules: always load modules with callbacks for the time being

Until config_GetPszChoices() learns to load modules when needed, any
module with a list callback must be loaded at all times.

The code previously assumed that plugins with list callbacks also had
action callbacks. This is not true.
parent e1bd4f03
...@@ -486,11 +486,10 @@ static int AllocatePluginFile (module_bank_t *bank, const char *abspath, ...@@ -486,11 +486,10 @@ static int AllocatePluginFile (module_bank_t *bank, const char *abspath,
module->b_loaded = false; module->b_loaded = false;
} }
/* For now we force loading if the module's config contains /* For now we force loading if the module's config contains callbacks.
* callbacks or actions.
* Could be optimized by adding an API call.*/ * Could be optimized by adding an API call.*/
for (size_t n = module->confsize, i = 0; i < n; i++) for (size_t n = module->confsize, i = 0; i < n; i++)
if (module->p_config[i].i_action) if (module->p_config[i].pf_update_list != NULL)
{ {
/* !unloadable not allowed for plugins with callbacks */ /* !unloadable not allowed for plugins with callbacks */
vlc_module_destroy (module); vlc_module_destroy (module);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment