Commit 3f9cee77 authored by Rémi Duraffort's avatar Rémi Duraffort

Check the returned values of malloc.

parent 26c4ced4
...@@ -819,11 +819,20 @@ char ** __module_GetModulesNamesForCapability( vlc_object_t *p_this, ...@@ -819,11 +819,20 @@ char ** __module_GetModulesNamesForCapability( vlc_object_t *p_this,
if( psz_module_capability && !strcmp( psz_module_capability, psz_capability ) ) if( psz_module_capability && !strcmp( psz_module_capability, psz_capability ) )
count++; count++;
} }
/* FIXME: must check the return value and modify the calling functions
to test for a NULL : potential segfault */
psz_ret = malloc( sizeof(char*) * (count+1) ); psz_ret = malloc( sizeof(char*) * (count+1) );
if( pppsz_longname ) if( pppsz_longname )
*pppsz_longname = malloc( sizeof(char*) * (count+1) ); *pppsz_longname = malloc( sizeof(char*) * (count+1) );
if( !psz_ret || ( pppsz_longname && *pppsz_longname == NULL ) )
{
msg_Err( p_this, "out of memory" );
free( psz_ret );
free( *pppsz_longname );
*pppsz_longname = NULL;
vlc_list_release( p_list );
return NULL;
}
j = 0; j = 0;
for( i = 0 ; i < p_list->i_count; i++) for( i = 0 ; i < p_list->i_count; i++)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment