Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc-2-2
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc-2-2
Commits
3e112f94
Commit
3e112f94
authored
Feb 20, 2010
by
Rémi Denis-Courmont
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
taglib meta writer: don't decode file path twice (core does it better)
parent
d459aab3
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
13 deletions
+4
-13
modules/meta_engine/taglib.cpp
modules/meta_engine/taglib.cpp
+4
-13
No files found.
modules/meta_engine/taglib.cpp
View file @
3e112f94
...
@@ -539,23 +539,16 @@ static int WriteMeta( vlc_object_t *p_this )
...
@@ -539,23 +539,16 @@ static int WriteMeta( vlc_object_t *p_this )
return
VLC_EGENERIC
;
return
VLC_EGENERIC
;
}
}
char
*
export_file
=
decode_URI_duplicate
(
p_export
->
psz_file
);
if
(
export_file
==
NULL
)
return
VLC_EGENERIC
;
#if defined(WIN32) || defined (UNDER_CE)
#if defined(WIN32) || defined (UNDER_CE)
wchar_t
wpath
[
MAX_PATH
+
1
];
wchar_t
wpath
[
MAX_PATH
+
1
];
if
(
!
MultiByteToWideChar
(
CP_UTF8
,
0
,
export_file
,
-
1
,
wpath
,
MAX_PATH
)
)
if
(
!
MultiByteToWideChar
(
CP_UTF8
,
0
,
p_export
->
psz_file
,
-
1
,
wpath
,
MAX_PATH
)
)
return
VLC_EGENERIC
;
return
VLC_EGENERIC
;
wpath
[
MAX_PATH
]
=
L'\0'
;
wpath
[
MAX_PATH
]
=
L'\0'
;
f
=
FileRef
(
wpath
);
f
=
FileRef
(
wpath
);
#else
#else
const
char
*
local_name
=
ToLocale
(
export
_file
);
const
char
*
local_name
=
ToLocale
(
p_export
->
psz
_file
);
if
(
!
local_name
)
if
(
!
local_name
)
{
free
(
export_file
);
return
VLC_EGENERIC
;
return
VLC_EGENERIC
;
}
f
=
FileRef
(
local_name
);
f
=
FileRef
(
local_name
);
LocaleFree
(
local_name
);
LocaleFree
(
local_name
);
#endif
#endif
...
@@ -563,13 +556,11 @@ static int WriteMeta( vlc_object_t *p_this )
...
@@ -563,13 +556,11 @@ static int WriteMeta( vlc_object_t *p_this )
if
(
f
.
isNull
()
||
!
f
.
tag
()
||
f
.
file
()
->
readOnly
()
)
if
(
f
.
isNull
()
||
!
f
.
tag
()
||
f
.
file
()
->
readOnly
()
)
{
{
msg_Err
(
p_this
,
"File %s can't be opened for tag writing"
,
msg_Err
(
p_this
,
"File %s can't be opened for tag writing"
,
export_file
);
p_export
->
psz_file
);
free
(
export_file
);
return
VLC_EGENERIC
;
return
VLC_EGENERIC
;
}
}
msg_Dbg
(
p_this
,
"Writing metadata for %s"
,
export_file
);
msg_Dbg
(
p_this
,
"Writing metadata for %s"
,
p_export
->
psz_file
);
free
(
export_file
);
Tag
*
p_tag
=
f
.
tag
();
Tag
*
p_tag
=
f
.
tag
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment